Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add Fleet Server Flyout Redesign #125640

Closed
9 tasks
hop-dev opened this issue Feb 15, 2022 · 6 comments · Fixed by #127786
Closed
9 tasks

[Fleet] Add Fleet Server Flyout Redesign #125640

hop-dev opened this issue Feb 15, 2022 · 6 comments · Fixed by #127786
Assignees
Labels
QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0

Comments

@hop-dev
Copy link
Contributor

hop-dev commented Feb 15, 2022

Second part of #80841.

From parent issue:

"We want to improve our agent installation instructions to minimize the time for the user to get started. We also want to maximize the percent of users who are successful installing it, so we want to remove friction points and provide assistance when they get stuck."

Implementation Checklist

Extracted from designs.

  • Redesign of fleet server commands component:
View design Screenshot 2022-02-15 at 12 01 45
  • Move add fleet server into it's own fly-out with 2 tabs:
    • Advanced tab (very similar to current setup)
      • remove download step
      • create tab
    • Quick start tab
      • Create tab
      • Create generate fleet server policy step component (generates policy and creates token):
View design Screenshot 2022-02-15 at 12 08 04
  • If no fleet server set up when going to add agent, show link to new add fleet server fly-out
View design Screenshot 2022-02-15 at 11 48 24
@hop-dev hop-dev added Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0 labels Feb 15, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jen-huang
Copy link
Contributor

@kpollich Assigning this one to you as @criamico took #125534, and we had planned for the overall enhancement to be split between you :)

@kpollich
Copy link
Member

@hop-dev @mostlyjason - Should these alterations also be reflected on the on-prem Fleet home page? Assuming we could display the flyout contents on this page or maybe just the "advanced" tab contents?

image

It'd be ideal to be able to have content shared completely between between the flyout and this view to avoid any code duplication.

@mostlyjason
Copy link
Contributor

@kpollich yes the content on the flyout and the empty state should be the same. I believe that's how it is today too. It'd be good to have both tabs available.

@amolnater-qasource
Copy link

amolnater-qasource commented May 6, 2022

Hi Team
We have revalidated this feature on latest 8.3 Snapshot self-managed environment and had below observations:

  • Two tabs Quickstart and Advanced are available under Agents tab.
  • Fleet Server installation commands are available for 5 different platforms.
  • Advanced mode further has Quickstart and Production mode.
  • When fleet server is unenrolled Add Fleet Server button is available under Add agent flyout.

Open Bugs:

Question Ticket:

Build details:
VERSION: 8.3.0 Snapshot self-managed
BUILD: 52512
COMMIT: df225b2

Please let us know if anything else is required from our end.
cc: @joshdover
Thanks

@amolnater-qasource
Copy link

Hi @hop-dev
We have completed our testing on this feature on 8.3 BC and 8.3 Snapshot builds.
Further we have 02 issue open related to async at links:

Hence we are marking this as QA:Validated.

Please let us know if any other testing is required on this from our end.
cc: @joshdover
Thanks

@amolnater-qasource amolnater-qasource added the QA:Validated Issue has been validated by QA label Jun 28, 2022
@amolnater-qasource amolnater-qasource removed the QA:Needs Validation Issue needs to be validated by QA label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants