Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] k8 instructions is lost after agent flyout redesign #130201

Closed
jen-huang opened this issue Apr 13, 2022 · 3 comments · Fixed by #130295
Closed

[Fleet] k8 instructions is lost after agent flyout redesign #130201

jen-huang opened this issue Apr 13, 2022 · 3 comments · Fixed by #130295
Assignees
Labels
bug Fixes for quality problems that affect the customer experience QA:Needs Dev Validation Issue needs to be validated by Dev QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0

Comments

@jen-huang
Copy link
Contributor

K8 instructions were added in: #127703

Flyout redesign was done in: #128381

After the redesign got merged, the K8 instructions including section for downloading the manifest is completely lost:

image

@jen-huang jen-huang added bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0 labels Apr 13, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@criamico
Copy link
Contributor

criamico commented Apr 14, 2022

I checked out the commit in after the PR was merged and the step with the instructions for kubernetes wasn't there. So I guess it got lost at some point and that's why I didn't pick those changes when I rebased my PR:

b1608537204_fleet_1
b1608537204_fleet_2

By looking at the screenshots in the PR description I see that there is a download section that is completely missing and should be added only when isK8s is true
https://user-images.githubusercontent.com/26270880/158374471-ab192255-0b05-4b40-add2-9d5dcb383fbc.png
https://user-images.githubusercontent.com/26270880/158374477-dfa6259f-568a-4784-882a-dd3be49a1197.png

@jen-huang jen-huang added QA:Ready for Testing Code is merged and ready for QA to validate QA:Needs Dev Validation Issue needs to be validated by Dev labels Apr 15, 2022
@amolnater-qasource
Copy link

Hi @jen-huang
We have revalidated this issue on latest 8.2 Snapshot and found it fixed now.

  • Kubernetes instructions are now available under Add Agent flyout when kubernetes integration is added to the policy.

Build details:
BUILD: 51972
COMMIT: 44f2776

Screenshots:
8
9

Hence marking this as QA:Validated.
Thanks

@amolnater-qasource amolnater-qasource added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience QA:Needs Dev Validation Issue needs to be validated by Dev QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants