Fix TSVB UX flow #12770
Fix TSVB UX flow #12770
Conversation
ppisljar
added
Feature:Visualizations
There was a problem hiding this comment.
yeah, indeed, this is missing from https://github.com/elastic/kibana/blob/40909bff424ce1818fda7fdb44c1ee1ff98895bd/src/core_plugins/metrics/public/kbn_vis_types/index.js.
not sure how this would get merged wrong. the refactor merge PR was just from the feature/visualize branch... git makes my head hurt
| @@ -51,14 +51,20 @@ export default function MetricsVisProvider(Private) { | |||
| interval: 'auto', | |||
| axis_position: 'left', | |||
| axis_formatter: 'number', | |||
| show_legend:1 | |||
| show_legend:1, | |||
| show_grid: 1 | |||
There was a problem hiding this comment.
This is gonna have issue with #12769 (which was just merged)
There was a problem hiding this comment.
the diffs are identical on this line, so I think it'll just merge without conflict (at least, it did when I tested this locally after checking out latest master).
|
@ppisljar Please add a Release Note: paragraph to the description describing what changed for users due to these changes, please include a screen shot if possible |
|
Here too, I think we should remove the release_note:fix label. This fixed a regression due to the refactor, but did not affect any v5 users. |
first commit closes #12759
second commit closes #12761
third commit closes #12763