Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSVB: Grid should be displayed by default for Time Series vis #12763

Closed
simianhacker opened this issue Jul 11, 2017 · 0 comments · Fixed by #12770
Closed

TSVB: Grid should be displayed by default for Time Series vis #12763

simianhacker opened this issue Jul 11, 2017 · 0 comments · Fixed by #12770
Assignees
@simianhacker @ppisljar
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available)

Comments

@simianhacker
Copy link
Member

The defaults state for a new TSVB visualization should have the show_grid key set to true. It's currently not set. This use to work before the #11786 refactor.

That attribute needs to be added to this section: https://github.com/elastic/kibana/blob/master/src/core_plugins/metrics/public/kbn_vis_types/index.js#L28-L54
@simianhacker simianhacker added Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) blocker bug Fixes for quality problems that affect the customer experience labels Jul 11, 2017
simianhacker added a commit to simianhacker/kibana that referenced this issue Jul 11, 2017
@simianhacker
Fixes elastic#12763 - Add show_grid to the default vis structure
7f2bcbf
@simianhacker simianhacker self-assigned this Jul 11, 2017
@ppisljar ppisljar mentioned this issue Jul 11, 2017
Merged
@ppisljar ppisljar self-assigned this Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simianhacker simianhacker

@ppisljar ppisljar

Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TSVB UX flow ppisljar/kibana
2 participants
@simianhacker @ppisljar