-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualize Refactor #11786
Visualize Refactor #11786
Conversation
TOCUSING VISUALIZATIONSThere are two ways to insert visualization in your page. Using
|
i'll be adding some docs this afternoon |
this should be in a working state now (except for TSVB and Maps) ... bug hunting can begin |
78bcc79
to
fe89eda
Compare
@weltenwort @lukasolson notice the mention of My problems with queryFilter:
@ppisljar you mentioned having a follow up discussion, could you include @weltenwort and @lukasolson as well? I'd like to get their input. |
Running list of examples here:
|
Can lower version of kibana (e.g. 5.2.1)use this fearture also? |
this will hopefully be part of 6.0, its still work in progress |
1eb4a16
to
da2bb34
Compare
0e3d49f
to
8f9f1db
Compare
c5addd2
to
3892f22
Compare
20bf21c
to
033806a
Compare
This reverts commit 3000221.
I reverted this changes #12711. The reason for this is that we broke Xpack. Should merge these together. |
Release Note: When creating new visualizations, developers are no longer restricted to using just Angular as a rendering technology. The changes now also enables developers to create custom editors that do not conform to the current sidebar-layout. Commonly used functionality - such as access to the query bar or timefilter - is now also exposed on the visualization object. This avoids the need to import individual modules from inside Kibana. These changes are a first step in a longer term effort to provide a robust long-lived programming interface for building visualizations in Kibana.
=====
This PR has 3 main goals:
<visualize> component accepts a savedSearch and takes care of loading data and showing visualization
<visualization> component takes visConfig and visData and takes care of rendering the visualization
visualization can now define its own requestHandler (responsible for loading data), responseHandler (responsible for converting data) and editor (responsible for configuring the visualization) which allows creating pretty much anything. timelion and tsvb now nicely fit inside this framework without using any hacks.
one way data flow makes reasoning about visualize editor easier