-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new response handlers for vislib #12661
Conversation
20bf21c
to
033806a
Compare
033806a
to
6fc6a41
Compare
93e70dd
to
cbaa7a3
Compare
cbaa7a3
to
f301fe3
Compare
c2bd94a
to
3c66c4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good.
@@ -1,7 +1,8 @@ | |||
import moment from 'moment'; | |||
|
|||
export default { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as you are updating all of the fixtures, how about exporting a named object instead of default?
const HierarchicalResponseHandlerProvider = function () { | ||
/*** | ||
* Prepares series out of esResponse. | ||
* each combination of metric, segment bucket and group bucket will add a series |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update comment for hierarchical response
43677da
to
c53dead
Compare
@@ -0,0 +1,23 @@ | |||
const tooltipFormatter = (event) => { | |||
const getValue = (agg) => { | |||
if (agg.value === 'y') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably be {{y}} or similar
c53dead
to
b5c75b3
Compare
b5c75b3
to
9087ac4
Compare
closing, will reimplement but based on tabify resposne not es response |
two response handlers:
goals:
as side effect two issues are fixed:
closes #12746
closes #10543
things that are still missing:
other charts should be converted to use one of the new request handlers as well, probably the third one will need to be added (table_data)
using visualizations is now fairly easy as the data object is no longer coupled to elastic search.