Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new response handlers for vislib #12661

Closed
wants to merge 9 commits into from
Closed

new response handlers for vislib #12661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fe7b248
series and hierarchical response handlers
ppisljar Jul 27, 2017
b497be5
tooltip formatter
ppisljar Jul 27, 2017
bbaca47
updating vislib data and dispatch to handle new data format
ppisljar Jul 27, 2017
a26602d
updating vislib_vis_type to handle new data format
ppisljar Jul 27, 2017
56f4d58
small updates to vislib (mostly renames)
ppisljar Jul 27, 2017
804bde3
updating visualizations to use new response handlers
ppisljar Jul 27, 2017
9b0664a
fixing existing unit tests
ppisljar Jul 27, 2017
7bd0917
adding new unit tests
ppisljar Jul 27, 2017
9087ac4
fixing based on review
ppisljar Jul 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core_plugins/kbn_vislib_vis_types/public/area.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ export default function PointSeriesVisType(Private) {
addTimeMarker: false,
},
},
responseHandler: 'series_data',
editorConfig: {
collections: {
positions: ['top', 'left', 'right', 'bottom'],
Expand Down
1 change: 1 addition & 0 deletions src/core_plugins/kbn_vislib_vis_types/public/gauge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ export default function GaugeVisType(Private) {
}
},
},
responseHandler: 'series_data',
editorConfig: {
collections: {
gaugeTypes: ['Arc', 'Circle', 'Metric'],
Expand Down
1 change: 1 addition & 0 deletions src/core_plugins/kbn_vislib_vis_types/public/goal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ export default function GoalVisType(Private) {
}
},
},
responseHandler: 'series_data',
editorConfig: {
collections: {
gaugeTypes: ['Arc', 'Circle', 'Metric'],
Expand Down
1 change: 1 addition & 0 deletions src/core_plugins/kbn_vislib_vis_types/public/heatmap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ export default function HeatmapVisType(Private) {
}]
},
},
responseHandler: 'series_data',
editorConfig: {
collections: {
legendPositions: [{
Expand Down
1 change: 1 addition & 0 deletions src/core_plugins/kbn_vislib_vis_types/public/histogram.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export default function PointSeriesVisType(Private) {
addTimeMarker: false,
},
},
responseHandler: 'series_data',
editorConfig: {
collections: {
positions: ['top', 'left', 'right', 'bottom'],
Expand Down
1 change: 1 addition & 0 deletions src/core_plugins/kbn_vislib_vis_types/public/horizontal_bar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ export default function PointSeriesVisType(Private) {
addTimeMarker: false,
},
},
responseHandler: 'series_data',
editorConfig: {
collections: {
positions: ['top', 'left', 'right', 'bottom'],
Expand Down
1 change: 1 addition & 0 deletions src/core_plugins/kbn_vislib_vis_types/public/line.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export default function PointSeriesVisType(Private) {
addTimeMarker: false,
},
},
responseHandler: 'series_data',
editorConfig: {
collections: {
positions: ['top', 'left', 'right', 'bottom'],
Expand Down
1 change: 1 addition & 0 deletions src/core_plugins/kbn_vislib_vis_types/public/metric.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ export default function MetricVisType(Private) {
}
},
},
responseHandler: 'series_data',
editorConfig: {
collections: {
gaugeTypes: ['Arc', 'Circle', 'Metric'],
Expand Down
1 change: 1 addition & 0 deletions src/core_plugins/kbn_vislib_vis_types/public/pie.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export default function HistogramVisType(Private) {
isDonut: false
},
},
responseHandler: 'hierarchical_data',
editorConfig: {
collections: {
legendPositions: [{
Expand Down
4 changes: 2 additions & 2 deletions src/core_plugins/kibana/public/discover/controllers/discover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import 'ui/timefilter';
import 'ui/share';
import 'ui/query_bar';
import { VisProvider } from 'ui/vis';
import { BasicResponseHandlerProvider } from 'ui/vis/response_handlers/basic';
import { seriesResponseHandlerProvider } from 'ui/vis/response_handlers/series_data';
import { DocTitleProvider } from 'ui/doc_title';
import PluginsKibanaDiscoverHitSortFnProvider from 'plugins/kibana/discover/_hit_sort_fn';
import { FilterBarQueryFilterProvider } from 'ui/filter_bar/query_filter';
Expand Down Expand Up @@ -117,7 +117,7 @@ function discoverController(
const docTitle = Private(DocTitleProvider);
const HitSortFn = Private(PluginsKibanaDiscoverHitSortFnProvider);
const queryFilter = Private(FilterBarQueryFilterProvider);
const responseHandler = Private(BasicResponseHandlerProvider).handler;
const responseHandler = Private(seriesResponseHandlerProvider).handler;
const notify = new Notifier({
location: 'Discover'
});
Expand Down
Loading