-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure we are working with data-series to avoid tooltip errors #13266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
Feature:Visualizations
Generic visualization features (in case no more specific feature label is available)
review
v5.6.0
v6.0.0
v6.1.0
v7.0.0
labels
Aug 1, 2017
thomasneirynck
changed the title
ensure we are working with data-series
Ensure we are working with data-series to avoid tooltip errors
Aug 1, 2017
ppisljar
approved these changes
Aug 1, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Aug 1, 2017
This fixes a regression introduced by elastic#13217.
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Aug 1, 2017
This fixes a regression introduced by elastic#13217.
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Aug 1, 2017
This fixes a regression introduced by elastic#13217.
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Aug 1, 2017
This fixes a regression introduced by elastic#13217.
thomasneirynck
added a commit
that referenced
this pull request
Aug 1, 2017
thomasneirynck
added a commit
that referenced
this pull request
Aug 1, 2017
thomasneirynck
added a commit
that referenced
this pull request
Aug 1, 2017
thomasneirynck
added a commit
that referenced
this pull request
Aug 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13255.
The #13217 introduced a bug. That object structure only works for series-charts.
Next to maps, it also fails e.g. on gauges.
This is a spot-fix. We are working on a more robust solution here #12661, but that one cannot be backported to v5.