Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we are working with data-series to avoid tooltip errors #13266

Merged
merged 1 commit into from
Aug 1, 2017

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Aug 1, 2017

Closes #13255.

The #13217 introduced a bug. That object structure only works for series-charts.

Next to maps, it also fails e.g. on gauges.

This is a spot-fix. We are working on a more robust solution here #12661, but that one cannot be backported to v5.

@thomasneirynck thomasneirynck added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v5.6.0 v6.0.0 v6.1.0 v7.0.0 labels Aug 1, 2017
@thomasneirynck thomasneirynck requested a review from ppisljar August 1, 2017 18:56
@thomasneirynck thomasneirynck changed the title ensure we are working with data-series Ensure we are working with data-series to avoid tooltip errors Aug 1, 2017
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasneirynck thomasneirynck merged commit 3838fa5 into elastic:master Aug 1, 2017
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Aug 1, 2017
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Aug 1, 2017
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Aug 1, 2017
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Aug 1, 2017
@thomasneirynck
Copy link
Contributor Author

Backports:
6.x: #13273
6.0: #13272
5.6: #13274
5.5: #13275

thomasneirynck added a commit that referenced this pull request Aug 1, 2017
thomasneirynck added a commit that referenced this pull request Aug 1, 2017
thomasneirynck added a commit that referenced this pull request Aug 1, 2017
thomasneirynck added a commit that referenced this pull request Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v5.5.2 v5.6.0 v6.0.0 v6.1.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hovering over heatmap throws error
2 participants