Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of KuiButtons in Clone Modal. #12050

Merged
merged 1 commit into from
May 27, 2017

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented May 26, 2017

When changes to the Buttons (#11878) were introduced, it caused tests for the Clone Modal (#10925) to fail because we didn't update the Buttons used by the Clone Modal. This is probably because the PR for changing the Buttons was created before the Clone Modal was updated.

Here's what the failure looks like:

renders DashboardCloneModal

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -35,24 +35,26 @@
         </div>
         <div
           class="kuiModalFooter"
         >
           <button
    -        class="kuiButton kuiButton--hollow"
    +        class="kuiButton"
             data-test-subj="cloneCancelButton"
    +        type="hollow"
           >
             <span
               class="kuiButton__inner"
             >
               <span>
                 Cancel
               </span>
             </span>
           </button>
           <button
    -        class="kuiButton kuiButton--primary"
    +        class="kuiButton"
             data-test-subj="cloneConfirmButton"
    +        type="primary"
           >
             <span
               class="kuiButton__inner"
             >
               <span>

@cjcenizal cjcenizal added :Sharing bug Fixes for quality problems that affect the customer experience v5.5.0 v6.0.0 labels May 26, 2017
@cjcenizal cjcenizal requested review from nreese and stacey-gammon May 26, 2017 23:38
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merged this into #12051 so we can get tests passing again

@spalger spalger merged commit 3c4f0ab into elastic:master May 27, 2017
@spalger
Copy link
Contributor

spalger commented May 27, 2017

5.x: 8bb0776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience v5.5.0 v6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants