Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around #11959 for now #12051

Merged
merged 3 commits into from
May 27, 2017

Conversation

spalger
Copy link
Contributor

@spalger spalger commented May 27, 2017

Until #11959 is resolved Kibana needs to continue to operate, so this works around the issue by hard-coding a list of languages into the API route

@spalger spalger requested a review from ycombinator May 27, 2017 00:14
@spalger spalger force-pushed the temp-fix/scripting-language-options branch from e0ac9cd to 0b84b99 Compare May 27, 2017 00:15
@spalger spalger changed the title Workaround #11959 for now Work around #11959 for now May 27, 2017
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works and code looks good.

LGTM!

@spalger spalger merged commit 522b0f7 into elastic:master May 27, 2017
@spalger spalger deleted the temp-fix/scripting-language-options branch May 27, 2017 01:39
snide pushed a commit to snide/kibana that referenced this pull request May 30, 2017
* Fix use of KuiButtons in Clone Modal.

* [scripts] stub scripts/languages api until elastic#11959 is fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants