[UI Framework] Rename "type" property to "buttonType" #11878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
suggested changes
May 17, 2017
| data-test-subj="confirmModalConfirmButton" | ||
| type="primary" |
There was a problem hiding this comment.
Looks like we'll need to update confirm_modal.js, which creates instances of KuiButton.
| BUTTON_TYPES.forEach(buttonType => { | ||
| describe(buttonType, () => { | ||
| test(`renders the ${buttonType} class`, () => { | ||
| const $button = render(<KuiButton buttonType={buttonType} />); |
There was a problem hiding this comment.
We'll need to update the test above this one to be:
test('HTML attributes are rendered', () => {
const $button = render(
<KuiButton
aria-label="aria label"
className="testClass1 testClass2"
data-test-subj="test subject string"
type="submit"
disabled
/>
);
expect($button)
.toMatchSnapshot();
});This will allow us to test that specifying the prop type="submit" renders as the HTML attribute type="submit".
We'll need to do this with the KuiLinkButton and KuiSubmitButton tests. too.
cjcenizal
approved these changes
May 17, 2017
| @@ -24,6 +24,7 @@ describe('KuiSubmitButton', () => { | |||
| aria-label="aria label" | |||
| className="testClass1 testClass2" | |||
| data-test-subj="test subject string" | |||
| type="submit" | |||
There was a problem hiding this comment.
I'm sorry, I forgot that this component will always apply the type="submit" attribute. So we can remove this from this test.
|
@cjcenizal was this supposed to go to 5.x too? #12050 was tagged with 5.x so I backported it, but this isn't there |
|
If so, when you backport them will you also revert dbd3c83? |
cjcenizal
pushed a commit
to cjcenizal/kibana
that referenced
this pull request
May 27, 2017
* change type property to buttonType * Update the tests to assert that the type HTML attribute is supported * remove type=submit from KuiSubmitButton since component automatically sets type
cjcenizal
added a commit
that referenced
this pull request
May 27, 2017
* [UI Framework] Rename "type" property to "buttonType" (#11878) * change type property to buttonType * Update the tests to assert that the type HTML attribute is supported * remove type=submit from KuiSubmitButton since component automatically sets type * Revert "Revert "Fix use of KuiButtons in Clone Modal."" This reverts commit dbd3c83.
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
* change type property to buttonType * Update the tests to assert that the type HTML attribute is supported * remove type=submit from KuiSubmitButton since component automatically sets type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11871
Renames
typeproperty tobuttonType.