removing old point series defaults #11958

ppisljar · 2017-05-22T15:49:46Z

fixes #11954, #11953, #12437

the old point series defaults were not removed and were causing the new properties to be overridden

stacey-gammon · 2017-05-23T16:14:30Z

Does this fix this issue too? #11953. I notice they both reference the y-axis.

ppisljar · 2017-05-25T10:25:23Z

jenkins, test this

stacey-gammon · 2017-05-26T19:29:40Z

src/ui/public/vislib_vis_type/vislib_vis_type.js

@@ -20,6 +20,7 @@ export function VislibVisTypeVislibVisTypeProvider(Private) {
    const updateIfSet = (from, to, prop, func) => {
      if (from[prop]) {
        to[prop] = func ? func(from[prop]) : from[prop];
+        delete from[prop];


Cool thanks for fixing this!

Minor, unrelated to this PR feedback - I think a comment for this updateParams function would be helpful. It was hard for me to figure out what was it was for. :) Plus then at some point way down the line if we stop supporting pre 5.2 we can get rid of the code.

I would like to see the comment added in this PR.

it is there @archanid

rhoboat · 2017-05-29T16:11:47Z

I'm new to this piece of code. Can someone explain why we designed it this way, with two objects containing point series defaults, one with old, one with new?

ppisljar · 2017-05-29T18:05:18Z

src/ui/public/vislib_vis_type/vislib_vis_type.js

@@ -14,12 +14,14 @@ export function VislibVisTypeVislibVisTypeProvider(Private) {
  const pointSeries = Private(AggResponsePointSeriesProvider);
  const VislibRenderbot = Private(VislibVisTypeVislibRenderbotProvider);

+  // converts old config format (pre 5.2) to the new one


@archanid ... i was refering to this comment

ppisljar · 2017-05-29T18:08:35Z

@archanid what exactly are you referring to with two objects (old and new) ? ... can you point to the code pls ? generally there is just one defaults object (for each vis type), which we changed quite a bit in 5.2, thats why updateParams is there to convert any visualization still saved in the old format to the new one (else 5.2 would not be backward compatible)

Wassim24 · 2017-05-30T11:10:25Z

Hello,

Is the 5.4.1 version available to be used along with docker ?

Thank you

thomasneirynck · 2017-05-30T18:31:07Z

hi @Wassim24, when Kibana 5.4.1 will be released, it will be available as a docker image. Instructions to pull it can be found here https://www.elastic.co/guide/en/kibana/current/_pulling_the_image.html.

For future reference, more general questions like yours are more suitable for the Q&A forums over at discuss.elastic.co/c/kibana. Use github for bug reports and feature requests, thanks.

thomasneirynck

wrt. #11954: it doesn't seem to work with visualizations which were created before this PR. The correct scaling method is not applied in the dashboard.

It does work when creating a new visualization from scratch.

Any ideas? It will require people to recreate their charts. Not that big of a deal, but wondering why this is happening.

wrt. #11953. This works!

ppisljar · 2017-06-05T14:53:38Z

@thomasneirynck fixed, works now with charts created before this PR as well

…es pre 5.2 chart)

thomasneirynck

I verified that it now works for different line-modes and for percentage display on dashboards, and that older saved objects display correctly.

I would not backport this to 5.5 until a new release is cut. This is not all that trivial of a fix, and there is a risk that it runs afoul of issues related to upgrading (e.g. Beats dashboards), things that are harder to catch here in isolation.

ppisljar · 2017-06-21T19:14:33Z

it is quite nasty bug that will prevent ppl from using vislib charts on dashboards .... (auch !)
... except with default settings

thomasneirynck · 2017-06-21T19:58:10Z

tested this for upgrading a Metric beats dashboard and this works on dashboards (5.5)

thomasneirynck · 2017-06-21T20:01:07Z

this does not fix the fontSize issue when the visualization is opened individually in the Visualize app. This requires a refresh. The UI element does not update as expected.

This fixes issues where properties from the visualizations saved in older versions were not applied to the Visualization. This also addressed the fontSize of metrics not being applied on the Dashboard.

thomasneirynck · 2017-06-21T20:13:27Z

backports:
5.5: #12456
5.x: #12457

This fixes issues where properties from the visualizations saved in older versions were not applied to the Visualization. This also addressed the fontSize of metrics not being applied on the Dashboard.

thomasneirynck · 2017-06-21T20:48:28Z

@ppisljar can you do the backport to 5.4? There are some merge conflicts (because gauge and metric don't exist on those branches) and don't want to resolve issues the wrong way

This fixes issues where properties from the visualizations saved in older versions were not applied to the Visualization. This also addressed the fontSize of metrics not being applied on the Dashboard.

NeVraX182 · 2017-10-22T18:34:44Z

I use Kibana 5.6.3 and still have the problem with my heatmaps, even when recreated. Maybe not related to this defect, but the feature seems almost completely broken : linear, log, square root, are all linear with different boundaries.

ppisljar added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix v5.4.1 v5.5.0 v6.0.0 labels May 22, 2017

ppisljar requested review from kobelb and thomasneirynck May 22, 2017 15:49

ppisljar mentioned this pull request May 26, 2017

Show line not working in Dashboard. #11651

Closed

ppisljar force-pushed the fix/point_series_defaults branch from 0db0b5a to c0ef67e Compare May 26, 2017 07:07

stacey-gammon reviewed May 26, 2017

View reviewed changes

ppisljar force-pushed the fix/point_series_defaults branch 2 times, most recently from d18a52a to 03cf6a7 Compare May 29, 2017 14:01

bhavyarm self-requested a review May 29, 2017 15:34

rhoboat self-requested a review May 29, 2017 16:06

ppisljar commented May 29, 2017

View reviewed changes

alexfrancoeur mentioned this pull request May 30, 2017

Revert or improve disabling of save button when creating a visualization #12082

Closed

thomasneirynck reviewed May 30, 2017

View reviewed changes

epixa added v5.4.2 and removed v5.4.1 labels Jun 1, 2017

ppisljar force-pushed the fix/point_series_defaults branch 2 times, most recently from fce26bc to 0e84bc5 Compare June 6, 2017 11:09

spalger added the v5.6.0 label Jun 7, 2017

epixa added the v5.4.3 label Jun 15, 2017

ppisljar added 4 commits June 20, 2017 12:33

adding comment

73c8a30

fixing tests

cba58c9

update params should only run if seriesParams is not yet set (indicat…

cccda99

…es pre 5.2 chart)

pie should not call update params

0799227

ppisljar force-pushed the fix/point_series_defaults branch from adba89b to 0799227 Compare June 20, 2017 10:34

fixing tests

b884842

tbragin mentioned this pull request Jun 21, 2017

Font size does not get honored for imported visualizations #12437

Closed

thomasneirynck reviewed Jun 21, 2017

View reviewed changes

fixing fontSize for gauge

dc6b2c7

ppisljar mentioned this pull request Jun 21, 2017

respect deprecated fontSize setting #12452

Closed

ppisljar added the blocker label Jun 21, 2017

thomasneirynck removed the blocker label Jun 21, 2017

thomasneirynck merged commit 3269965 into elastic:master Jun 21, 2017

stacey-gammon mentioned this pull request Jun 27, 2017

Parameters of Kibana's visualization doesn't take effect in dashboard #12495

Closed

ppisljar mentioned this pull request Jul 5, 2017

Chart settings don't update existing charts correctly #12598

Closed

thomasneirynck added v5.5.1 and removed v5.4.3 v5.5.0 labels Jul 10, 2017

thomasneirynck mentioned this pull request Jul 10, 2017

Split series gets stacked in dashboard #12677

Closed

ppisljar mentioned this pull request Jul 20, 2017

Y-Axes / X-Axis (Position Bottom) - Bar Graph - Mode Not Saving to "Normal" Reverts to "Stacked" #12952

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

removing old point series defaults #11958

removing old point series defaults #11958

ppisljar commented May 22, 2017 •

edited by thomasneirynck

Loading

stacey-gammon commented May 23, 2017

ppisljar commented May 25, 2017

stacey-gammon May 26, 2017

rhoboat May 29, 2017

ppisljar May 29, 2017

rhoboat commented May 29, 2017

ppisljar May 29, 2017

ppisljar commented May 29, 2017

Wassim24 commented May 30, 2017

thomasneirynck commented May 30, 2017

thomasneirynck left a comment

ppisljar commented Jun 5, 2017

thomasneirynck left a comment

ppisljar commented Jun 21, 2017 •

edited

Loading

thomasneirynck commented Jun 21, 2017 •

edited

Loading

thomasneirynck commented Jun 21, 2017

thomasneirynck commented Jun 21, 2017 •

edited

Loading

thomasneirynck commented Jun 21, 2017

NeVraX182 commented Oct 22, 2017

removing old point series defaults #11958

removing old point series defaults #11958

Conversation

ppisljar commented May 22, 2017 • edited by thomasneirynck Loading

stacey-gammon commented May 23, 2017

ppisljar commented May 25, 2017

stacey-gammon May 26, 2017

Choose a reason for hiding this comment

rhoboat May 29, 2017

Choose a reason for hiding this comment

ppisljar May 29, 2017

Choose a reason for hiding this comment

rhoboat commented May 29, 2017

ppisljar May 29, 2017

Choose a reason for hiding this comment

ppisljar commented May 29, 2017

Wassim24 commented May 30, 2017

thomasneirynck commented May 30, 2017

thomasneirynck left a comment

Choose a reason for hiding this comment

ppisljar commented Jun 5, 2017

thomasneirynck left a comment

Choose a reason for hiding this comment

ppisljar commented Jun 21, 2017 • edited Loading

thomasneirynck commented Jun 21, 2017 • edited Loading

thomasneirynck commented Jun 21, 2017

thomasneirynck commented Jun 21, 2017 • edited Loading

thomasneirynck commented Jun 21, 2017

NeVraX182 commented Oct 22, 2017

ppisljar commented May 22, 2017 •

edited by thomasneirynck

Loading

ppisljar commented Jun 21, 2017 •

edited

Loading

thomasneirynck commented Jun 21, 2017 •

edited

Loading

thomasneirynck commented Jun 21, 2017 •

edited

Loading