Chart settings don't update existing charts correctly

[pemontto]

Kibana version: 5.4.3

Elasticsearch version: 5.4.3

Server OS version: Centos 7

Browser version: Chrome 59

Browser OS version: Mac OS X 10.12

Original install method (e.g. download page, yum, from source, etc.): tar

Description of the problem including expected versus actual behavior:
When editing some line or bar charts created before 5.4 changing some settings doesn't have any effect. In particular changing the line mode from smoothed to stepped to straight doesn't have any effect, this includes after saving and viewing on the viz on a dashboard.

Steps to reproduce:

1. An existing line chart charting a terms agg (y-axis) of DKIM pass and fail over time (@timestamp)
   vis state:

{
  "title": "DMARC - Report Frequency",
  "type": "line",
  "params": {
    "shareYAxis": true,
    "addTooltip": true,
    "addLegend": true,
    "showCircles": true,
    "smoothLines": true,
    "interpolate": "linear",
    "scale": "linear",
    "drawLinesBetweenPoints": true,
    "radiusRatio": 9,
    "times": [],
    "addTimeMarker": false,
    "defaultYExtents": false,
    "setYExtents": false,
    "yAxis": {}
  },
  "aggs": [
    {
      "id": "1",
      "type": "count",
      "schema": "metric",
      "params": {}
    },
    {
      "id": "2",
      "type": "date_histogram",
      "schema": "segment",
      "params": {
        "field": "@timestamp",
        "interval": "d",
        "customInterval": "2h",
        "min_doc_count": 1,
        "extended_bounds": {}
      }
    },
    {
      "id": "3",
      "type": "terms",
      "schema": "group",
      "params": {
        "field": "dkim",
        "size": 5,
        "order": "desc",
        "orderBy": "1"
      }
    }
  ],
  "listeners": {}
}

2. Edit the vis and change the line mode to stepped, straight, smoothed and no changes take place. The vis state now looks like:

{
  "title": "@DMARC - Report Frequency",
  "type": "line",
  "params": {
    "shareYAxis": true,
    "addTooltip": true,
    "addLegend": true,
    "showCircles": true,
    "smoothLines": true,
    "interpolate": "linear",
    "scale": "linear",
    "drawLinesBetweenPoints": true,
    "radiusRatio": 9,
    "times": [],
    "addTimeMarker": false,
    "defaultYExtents": false,
    "setYExtents": false,
    "yAxis": {},
    "grid": {
      "categoryLines": false,
      "style": {
        "color": "#eee"
      }
    },
    "categoryAxes": [
      {
        "id": "CategoryAxis-1",
        "type": "category",
        "position": "bottom",
        "show": true,
        "style": {},
        "scale": {
          "type": "linear"
        },
        "labels": {
          "show": true,
          "truncate": 100
        },
        "title": {
          "text": "@timestamp per day"
        }
      }
    ],
    "valueAxes": [
      {
        "id": "ValueAxis-1",
        "name": "LeftAxis-1",
        "type": "value",
        "position": "left",
        "show": true,
        "style": {},
        "scale": {
          "type": "linear",
          "mode": "normal"
        },
        "labels": {
          "show": true,
          "rotate": 0,
          "filter": false,
          "truncate": 100
        },
        "title": {
          "text": "Count"
        }
      }
    ],
    "seriesParams": [
      {
        "show": true,
        "mode": "normal",
        "type": "line",
        "drawLinesBetweenPoints": true,
        "showCircles": true,
        "interpolate": "step-after",
        "lineWidth": 2,
        "data": {
          "id": "1",
          "label": "Count"
        },
        "valueAxis": "ValueAxis-1"
      }
    ],
    "legendPosition": "right"
  },
  "aggs": [
    {
      "id": "1",
      "enabled": true,
      "type": "count",
      "schema": "metric",
      "params": {}
    },
    {
      "id": "2",
      "enabled": true,
      "type": "date_histogram",
      "schema": "segment",
      "params": {
        "field": "@timestamp",
        "interval": "d",
        "customInterval": "2h",
        "min_doc_count": 1,
        "extended_bounds": {}
      }
    },
    {
      "id": "3",
      "enabled": true,
      "type": "terms",
      "schema": "group",
      "params": {
        "field": "dkim",
        "size": 5,
        "order": "desc",
        "orderBy": "1"
      }
    }
  ],
  "listeners": {}
}

Errors in browser console (if relevant):
No errors or warning logged

[pemontto]

I'm assuming a related bug, when I edit a chart and change the X-axis position to be on the left or right all labels disappear except one. I can produce an example of that if required.

[ppisljar]

closed by #11958