Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert or improve disabling of save button when creating a visualization #12082

Closed
alexfrancoeur opened this issue May 30, 2017 · 1 comment · Fixed by #12152
Closed

Revert or improve disabling of save button when creating a visualization #12082

alexfrancoeur opened this issue May 30, 2017 · 1 comment · Fixed by #12152
Assignees
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v5.5.0

Comments

@alexfrancoeur
Copy link

While I generally like the disabling of a save button if nothing can be saved I believe the implementation may need to be revisited. This is related to #11575. There are two main regressions as I see it.

First, you now need to hit the play button to save a visualization if you've adjusted the global timeframe via the visualization

may-30-2017 15-20-58
Steps to reproduce:

  1. Create a visualization w/ date histogram on the y-axis
  2. Hit play
  3. Zoom in by dragging and dropping on a visualization
  4. Cannot save until you hit play even though the visualization has already been updated

The second regression I see is that you can no longer rename or save as a new visualization without making changes.

  1. Open up a visualization
  2. Hitting save to rename is blocked

We could adjust be introducing more tabs and even re-using Dashboards clone functionality (#10925). Rename would also need it's own here.

cc: @ppisljar's & his PR #11958

@alexfrancoeur alexfrancoeur added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) bug Fixes for quality problems that affect the customer experience labels May 30, 2017
@ppisljar
Copy link
Member

i think its actually not the save button that is problematic but the visualize editor "play" button ... (which should not get enabled when you 'zoom in' on your chart for example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v5.5.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants