-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data.search] Remove warning toast #117252
[data.search] Remove warning toast #117252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
please note that backport will have to be manual because of #115945 that went only into 7.16 and 7.15, but not 8.0
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @lukasolson |
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
* [data.search] Remove toast notification for warnings * Update docs * Review feedback Co-authored-by: Kibana Machine <[email protected]>
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
* [data.search] Remove toast notification for warnings * Update docs * Review feedback Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Lukas Olson <[email protected]>
* [data.search] Remove toast notification for warnings * Update docs * Review feedback Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # src/plugins/data/public/search/fetch/handle_response.tsx
* [data.search] Remove toast notification for warnings * Update docs * Review feedback Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # src/plugins/data/public/search/fetch/handle_response.tsx Co-authored-by: Kibana Machine <[email protected]>
Summary
Resolves #116949.
In #103744 we added a notification for warnings that are returned from ES APIs (see elastic/elasticsearch#17804). These turned out to be spammy and unhelpful in some scenarios, so we are turning them off until we can review which warnings should actually be surfaced to end users. These warnings will still show up in the ES deprecation logs.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers