Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.16] Ignore security disabled HTTP response header #115945

Merged
merged 4 commits into from
Oct 26, 2021
Merged

[7.16] Ignore security disabled HTTP response header #115945

merged 4 commits into from
Oct 26, 2021

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Oct 21, 2021 •
edited
Loading

Summary

Close #115632

Do not show a warning toast that includes Elasticsearch built-in security features are not enabled substring.
Note: needed only for 7.16 and 7.15

How to test

You'll need a 7.16 deployment without explicitly disabled security. Go to Discover: in 7.16 you'll see warning toasts, in this pr we don't show them.

Release note

Do not show security disabled warning when running searches

@Dosant Dosant added bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana Team:AppServicesSv v7.15.2 v7.16.0 release_note:fix auto-backport Deprecated - use backport:version if exact versions are needed labels Oct 21, 2021
@Dosant Dosant requested review from lukasolson and a team October 21, 2021 13:53
@Dosant Dosant marked this pull request as ready for review October 25, 2021 09:15
@Dosant
Copy link
Contributor Author

Dosant commented Oct 25, 2021

@elasticmachine merge upstream

@Dosant
Copy link
Contributor Author

Dosant commented Oct 25, 2021

@elasticmachine merge upstream

ppisljar
ppisljar approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@Dosant
Copy link
Contributor Author

Dosant commented Oct 26, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 464.8KB 464.9KB +97.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit 77988c8 into elastic:7.16 Oct 26, 2021
Dosant added a commit to Dosant/kibana that referenced this pull request Oct 27, 2021
@Dosant
Ignore security disabled HTTP response header (elastic#115945)
3c93010
@Dosant Dosant mentioned this pull request Oct 27, 2021
Merged
Dosant added a commit that referenced this pull request Oct 27, 2021
@Dosant
Ignore security disabled HTTP response header (#115945) (#116416)
c310e3c
@Dosant Dosant mentioned this pull request Oct 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@lukasolson lukasolson Awaiting requested review from lukasolson

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana release_note:fix v7.15.2 v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dosant @kibanamachine @ppisljar