Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data.search] Remove warning toast #117252

Merged
merged 7 commits into from
Nov 9, 2021
Merged

[data.search] Remove warning toast #117252

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
35a14e8
[data.search] Remove toast notification for warnings
lukasolson Nov 2, 2021
5a1550b
Update docs
lukasolson Nov 2, 2021
6a6159d
Review feedback
lukasolson Nov 3, 2021
9def467
Merge branch 'main' into search-remove-warning-toast
lukasolson Nov 3, 2021
3869d9a
Merge branch 'main' into search-remove-warning-toast
kibanamachine Nov 9, 2021
67639d2
Merge branch 'main' into search-remove-warning-toast
lukasolson Nov 9, 2021
080725f
Merge branch 'main' into search-remove-warning-toast
kibanamachine Nov 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/data/common/search/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export interface IKibanaSearchResponse<RawResponse = any> {
isRestored?: boolean;

/**
* Optional warnings that should be surfaced to the end user
* Optional warnings returned from Elasticsearch (for example, deprecation warnings)
*/
warning?: string;

Expand Down
12 changes: 1 addition & 11 deletions src/plugins/data/public/search/fetch/handle_response.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,7 @@ import { getNotifications } from '../../services';
import { SearchRequest } from '..';

export function handleResponse(request: SearchRequest, response: IKibanaSearchResponse) {
const { rawResponse, warning } = response;
if (warning) {
getNotifications().toasts.addWarning({
title: i18n.translate('data.search.searchSource.fetch.warningMessage', {
defaultMessage: 'Warning: {warning}',
values: {
warning,
},
}),
});
}
const { rawResponse } = response;

if (rawResponse.timed_out) {
getNotifications().toasts.addWarning({
Expand Down