Alert creation and freeform selection #111883

smith · 2021-09-10T16:47:35Z

Allow selecting any service name, transaction type (where appropriate), and environment when creating and editing rules, both in APM and Stack Management.

Create /internal/apm/suggestions endpoint that uses terms_enum
Use combo box for environment, service name, and transaction type with suggestions endpoint on all alerts
Remove "Go to APM" callouts on new alert creation
Wrap calls to createCallApmApi in alert triggers with useEffect
Use getEnvironmentLabel for value in environment field expression
Make all AlertParams fields optional (except in latency threshold alert)
Add e2e tests for creating an alert
Remove NewAlertEmptyPrompt component and isNewApmRuleFromStackManagement helper
Replace maxServiceEnvironments and maxServiceSelections config options with maxSuggestions advanced setting.

Fixes #106786

elasticmachine · 2021-09-28T20:20:56Z

Pinging @elastic/apm-ui (Team:apm)

sorenlouv

Looks great!

sorenlouv · 2021-09-28T21:51:23Z

.../apm/public/components/alerting/error_count_alert_trigger/error_count_alert_trigger.test.tsx

+import * as stories from './error_count_alert_trigger.stories';
+import { composeStories } from '@storybook/testing-react';
+
+const { CreatingInApmFromService } = composeStories(stories);


Yay! Great to see storybook and testing-library playing well together. What's your impression of this so far?

It's pretty great. Centralizes most of the boilerplate and makes injecting data easy.

sorenlouv · 2021-09-28T21:56:55Z

x-pack/plugins/apm/public/components/shared/suggestions_select/index.tsx

+      isLoading={status === FETCH_STATUS.LOADING}
+      onChange={handleChange}
+      onCreateOption={handleCreateOption}
+      onSearchChange={debounce(setSearchValue, 500)}


I think we want to use throttle to allow continuous results to come through even as the user is typing.

I think debounce is more appropriate here. throttle will just keep making requests. I found https://redd.one/blog/debounce-vs-throttle useful.

sorenlouv · 2021-09-28T22:01:26Z

x-pack/plugins/apm/server/index.ts

-  deprecations: ({ deprecate }) => [deprecate('enabled', '8.0.0')],
+  deprecations: ({ deprecate, renameFromRoot }) => [
+    deprecate('enabled', '8.0.0'),
+    renameFromRoot(


@ogupte I think you can use renameFromRoot when working on #108160

sorenlouv · 2021-09-28T22:03:16Z

x-pack/plugins/apm/server/index.ts

+    deprecate('enabled', '8.0.0'),
+    renameFromRoot(
+      'xpack.apm.maxServiceEnvironments',
+      `uiSettings.overrides[${maxSuggestions}]`


What does this actually do? It looks like we are not using xpack.apm.maxServiceEnvironments anywhere in the ui anymore.

nvm, I understand now that we are basically renaming the config setting but allowing users to keep using the old name.

sorenlouv · 2021-09-29T10:05:40Z

x-pack/plugins/apm/server/routes/suggestions.ts

+import { createApmServerRouteRepository } from './create_apm_server_route_repository';
+
+const suggestionsRoute = createApmServerRoute({
+  endpoint: 'GET /internal/apm/suggestions',


Thanks for creating this as an internal api.
I recall there was an issue for doing this in Kibana but can't find it now. I think we should have an APM specific issue so we have it captured on our board too.

Created an issue for internal apis here: #113383

kibanamachine · 2021-09-29T16:16:28Z

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`observability`	232	234	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	2.7MB	2.7MB	-2.0KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`apm`	36	37	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`observability`	28.6KB	28.6KB	+6.0B

Unknown metric groups

API count

id	before	after	diff
`observability`	232	234	+2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Allow selecting any service name, transaction type (where appropriate), and environment when creating and editing rules, both in APM and Stack Management. - Create /internal/apm/suggestions endpoint that uses `terms_enum` - Use combo box for environment, service name, and transaction type with suggestions endpoint on all alerts - Remove "Go to APM" callouts on new alert creation - Wrap calls to `createCallApmApi` in alert triggers with `useEffect` - Use `getEnvironmentLabel` for value in environment field expression - Make all `AlertParams` fields optional (except in latency threshold alert) - Add e2e tests for creating an alert - Remove `NewAlertEmptyPrompt` component and `isNewApmRuleFromStackManagement` helper - Replace `maxServiceEnvironments` and `maxServiceSelections` config options with `maxSuggestions` advanced setting. ![CleanShot 2021-09-28 at 10 35 58](https://user-images.githubusercontent.com/9912/135119948-e247615a-d235-4feb-b197-b803f165ad1e.gif) Fixes elastic#106786

kibanamachine · 2021-09-29T16:21:43Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

Allow selecting any service name, transaction type (where appropriate), and environment when creating and editing rules, both in APM and Stack Management. - Create /internal/apm/suggestions endpoint that uses `terms_enum` - Use combo box for environment, service name, and transaction type with suggestions endpoint on all alerts - Remove "Go to APM" callouts on new alert creation - Wrap calls to `createCallApmApi` in alert triggers with `useEffect` - Use `getEnvironmentLabel` for value in environment field expression - Make all `AlertParams` fields optional (except in latency threshold alert) - Add e2e tests for creating an alert - Remove `NewAlertEmptyPrompt` component and `isNewApmRuleFromStackManagement` helper - Replace `maxServiceEnvironments` and `maxServiceSelections` config options with `maxSuggestions` advanced setting. ![CleanShot 2021-09-28 at 10 35 58](https://user-images.githubusercontent.com/9912/135119948-e247615a-d235-4feb-b197-b803f165ad1e.gif) Fixes #106786 Co-authored-by: Nathan L Smith <[email protected]>

smith added 30 commits September 10, 2021 11:06

create alert fixes

ff386a3

add select component

3b63130

env sel

b961e17

Merge remote-tracking branch 'upstream/master' into nls/create-alerts

947b777

Merge remote-tracking branch 'upstream/master' into nls/create-alerts

487f73d

working env selection

1af6117

exclude e2e from server watch paths

11420c9

e2e

5cbe080

Merge remote-tracking branch 'upstream/master' into nls/create-alerts

d88e1ed

Record transaction duration alerts in microseconds

085eb11

Merge remote-tracking branch 'upstream/master' into nls/create-alerts

e020c0c

some suggestion stuff

0943d8c

Merge remote-tracking branch 'upstream/master' into nls/create-alerts

8af342a

rename fixes

81e6ec8

Merge remote-tracking branch 'upstream/master' into nls/create-alerts

87837c4

prettier fix

6662aaa

Merge remote-tracking branch 'upstream/master' into nls/create-alerts

40c491c

roll back change to get all environments

eba1eaf

environment suggestions

99c5560

transaction type etc

9ab39af

remove old callout stuff

376d9d3

use new setting

465756b

Merge remote-tracking branch 'upstream/master' into nls/create-alerts

f39cd75

Merge remote-tracking branch 'upstream/master' into nls/create-alerts

974c493

tests and initial trans type option

2823f84

get all options working

4b14a34

Merge remote-tracking branch 'upstream/master' into nls/create-alerts

6675c2b

Merge remote-tracking branch 'upstream/master' into nls/create-alerts

8039414

undo rename

86855ec

suggestion api updates

7d08056

smith added 5 commits September 27, 2021 20:08

refactor

f4461d8

Merge remote-tracking branch 'upstream/master' into nls/create-alerts

88a8789

test fixes

453711e

Merge remote-tracking branch 'upstream/master' into nls/create-alerts

b025b30

type fix

b9e6659

smith added release_note:enhancement v7.16.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Sep 28, 2021

smith marked this pull request as ready for review September 28, 2021 15:41

smith requested review from a team as code owners September 28, 2021 15:41

Merge remote-tracking branch 'upstream/master' into nls/create-alerts

8831793

botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 28, 2021

sorenlouv approved these changes Sep 28, 2021

View reviewed changes

pgayvallet approved these changes Sep 29, 2021

View reviewed changes

sorenlouv reviewed Sep 29, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/master' into nls/create-alerts

959fc25

smith merged commit f4a95f9 into elastic:master Sep 29, 2021

smith deleted the nls/create-alerts branch September 29, 2021 16:18

kibanamachine mentioned this pull request Sep 29, 2021

[7.x] Alert creation and freeform selection (#111883) #113444

Merged

smith mentioned this pull request Sep 29, 2021

[APM] Use SuggestionsSelect in settings #113468

Closed

3 tasks

This was referenced Apr 26, 2022

[APM] Remove xpack.apm.maxServiceEnvironments #130956

Closed

[APM] Rename xpack.apm.maxServiceSelections to xpack.apm.maxServiceSelection in config deprecations #130975

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alert creation and freeform selection #111883

Alert creation and freeform selection #111883

smith commented Sep 10, 2021 •

edited

Loading

elasticmachine commented Sep 28, 2021

sorenlouv left a comment

sorenlouv Sep 28, 2021

smith Sep 29, 2021

sorenlouv Sep 28, 2021

smith Sep 29, 2021

sorenlouv Sep 28, 2021

sorenlouv Sep 28, 2021

sorenlouv Sep 28, 2021 •

edited

Loading

sorenlouv Sep 29, 2021 •

edited

Loading

sorenlouv Sep 29, 2021

kibanamachine commented Sep 29, 2021

API count

kibanamachine commented Sep 29, 2021

Alert creation and freeform selection #111883

Alert creation and freeform selection #111883

Conversation

smith commented Sep 10, 2021 • edited Loading

elasticmachine commented Sep 28, 2021

sorenlouv left a comment

Choose a reason for hiding this comment

sorenlouv Sep 28, 2021

Choose a reason for hiding this comment

smith Sep 29, 2021

Choose a reason for hiding this comment

sorenlouv Sep 28, 2021

Choose a reason for hiding this comment

smith Sep 29, 2021

Choose a reason for hiding this comment

sorenlouv Sep 28, 2021

Choose a reason for hiding this comment

sorenlouv Sep 28, 2021

Choose a reason for hiding this comment

sorenlouv Sep 28, 2021 • edited Loading

Choose a reason for hiding this comment

sorenlouv Sep 29, 2021 • edited Loading

Choose a reason for hiding this comment

sorenlouv Sep 29, 2021

Choose a reason for hiding this comment

kibanamachine commented Sep 29, 2021

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

History

kibanamachine commented Sep 29, 2021

💚 Backport successful

smith commented Sep 10, 2021 •

edited

Loading

sorenlouv Sep 28, 2021 •

edited

Loading

sorenlouv Sep 29, 2021 •

edited

Loading