Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Deprecate apm_oss app #108160

Closed
sorenlouv opened this issue Aug 11, 2021 · 1 comment · Fixed by #113364
Closed

[APM] Deprecate apm_oss app #108160

sorenlouv opened this issue Aug 11, 2021 · 1 comment · Fixed by #113364
Assignees
Labels
apm:test-plan-7.16.0 apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture v7.16.0 v8.0.0

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Aug 11, 2021

The apm_oss app is no longer needed since everything in Kibana is now under the same license.
We should therefore deprecate all the options in apm_oss and replace them with identical options in xpack.apm.

Dure to backwards compatibility we'll have to keep the old settings around for the foreseeable future but with deprecation warnings.

export const config = {
schema: schema.object({
enabled: schema.boolean({ defaultValue: true }),
transactionIndices: schema.string({ defaultValue: 'apm-*' }),
spanIndices: schema.string({ defaultValue: 'apm-*' }),
errorIndices: schema.string({ defaultValue: 'apm-*' }),
metricsIndices: schema.string({ defaultValue: 'apm-*' }),
sourcemapIndices: schema.string({ defaultValue: 'apm-*' }),
onboardingIndices: schema.string({ defaultValue: 'apm-*' }),
indexPattern: schema.string({ defaultValue: 'apm-*' }),
fleetMode: schema.boolean({ defaultValue: true }),
}),
deprecations,
};

@sorenlouv sorenlouv added 8.0.0 Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture v7.16.0 labels Aug 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@spalger spalger added v8.0.0 and removed 8.0.0 labels Aug 11, 2021
@sorenlouv sorenlouv removed their assignment Sep 10, 2021
ogupte added a commit that referenced this issue Oct 13, 2021
)

* [APM] Removes the apm_oss plugin and deprecates related configs (#108160)

* removes commented lines

* fixes typescript errors

* performs start up migration on the saved objects mapping for apm-indices

* removes all references to the deprecated apm_oss.* config paths in APM

* fixes missing bundle error

* fixes type error

* fixes eslint error with disabled rules

* fixes saved object mappings for es_archvices for tests

* fixes eslint error

* Updates default index values to include the more general apm-*. Fixes broken tests.

* removing unused configs from the config path migration: apm_oss.indexPattern and apm_oss.fleetMode

* - replaces full index configuration paths with references in the `xpack.apm.indices` namespace
- removes mergeConfig function and test

* fixes proxy mock object in unit test

* fixes linting issues

* PR feedback and failed test

* changes the configs at `xpack.apm.indices.*` from plural to singular to match `processor.event` values
ogupte added a commit to ogupte/kibana that referenced this issue Oct 13, 2021
…tic#113364)

* [APM] Removes the apm_oss plugin and deprecates related configs (elastic#108160)

* removes commented lines

* fixes typescript errors

* performs start up migration on the saved objects mapping for apm-indices

* removes all references to the deprecated apm_oss.* config paths in APM

* fixes missing bundle error

* fixes type error

* fixes eslint error with disabled rules

* fixes saved object mappings for es_archvices for tests

* fixes eslint error

* Updates default index values to include the more general apm-*. Fixes broken tests.

* removing unused configs from the config path migration: apm_oss.indexPattern and apm_oss.fleetMode

* - replaces full index configuration paths with references in the `xpack.apm.indices` namespace
- removes mergeConfig function and test

* fixes proxy mock object in unit test

* fixes linting issues

* PR feedback and failed test

* changes the configs at `xpack.apm.indices.*` from plural to singular to match `processor.event` values
# Conflicts:
#	x-pack/test/functional/es_archives/cases/migrations/7.16.0_space/mappings.json
#	x-pack/test/functional/es_archives/security_solution/timelines/7.15.0_space/mappings.json
ogupte added a commit that referenced this issue Oct 13, 2021
) (#114873)

* [APM] Removes the apm_oss plugin and deprecates related configs (#108160)

* removes commented lines

* fixes typescript errors

* performs start up migration on the saved objects mapping for apm-indices

* removes all references to the deprecated apm_oss.* config paths in APM

* fixes missing bundle error

* fixes type error

* fixes eslint error with disabled rules

* fixes saved object mappings for es_archvices for tests

* fixes eslint error

* Updates default index values to include the more general apm-*. Fixes broken tests.

* removing unused configs from the config path migration: apm_oss.indexPattern and apm_oss.fleetMode

* - replaces full index configuration paths with references in the `xpack.apm.indices` namespace
- removes mergeConfig function and test

* fixes proxy mock object in unit test

* fixes linting issues

* PR feedback and failed test

* changes the configs at `xpack.apm.indices.*` from plural to singular to match `processor.event` values
# Conflicts:
#	x-pack/test/functional/es_archives/cases/migrations/7.16.0_space/mappings.json
#	x-pack/test/functional/es_archives/security_solution/timelines/7.15.0_space/mappings.json
@ogupte ogupte added the apm:test-plan-done Pull request that was successfully tested during the test plan label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:test-plan-7.16.0 apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants