Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Use SuggestionsSelect in settings #113468

Closed
3 tasks done
smith opened this issue Sep 29, 2021 · 5 comments · Fixed by #122648
Closed
3 tasks done

[APM] Use SuggestionsSelect in settings #113468

smith opened this issue Sep 29, 2021 · 5 comments · Fixed by #122648
Assignees
@kpatticha
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan apm:ux-refresh Team:APM All issues that need APM UI Team support v8.2.0

Comments

@smith
Copy link
Contributor

smith commented Sep 29, 2021 •
edited by kpatticha
Loading

The SuggestionsSelect component was added in #111883.

This component can also be used in other places:

  • Agent configuration selection of service and environment
  • Anomaly detection setup selection of environment -- it's already done
  • Custom links selection of fields

Update these forms to use SuggestionsSelect.

#117535
@smith smith added Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture labels Sep 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv mentioned this issue Nov 8, 2021
Closed
@sorenlouv sorenlouv added [zube]: Backlog and removed technical debt Improvement of the software architecture and operational architecture [zube]: 8.0 v8.0.0 labels Nov 9, 2021
@kpatticha kpatticha self-assigned this Jan 5, 2022
@kpatticha kpatticha mentioned this issue Jan 11, 2022
Merged
@kpatticha
Copy link
Contributor

As for the Custom links selection of fields based on the documentation there are always only 4 options. I don't think it's the suggestionsSelect would be usefull to the end use

@smith
Copy link
Contributor Author

smith commented Jan 11, 2022

As for the Custom links selection of fields based on the documentation there are always only 4 options. I don't think it's the suggestionsSelect would be usefull to the end use

It wouldn't be used for the field, but for the Value. So in this case it could suggest service.name values:

CleanShot 2022-01-11 at 08 52 52@2x

@kpatticha
Copy link
Contributor

oh I see, now it makes sense @smith thanks for the clarification

@kpatticha kpatticha mentioned this issue Apr 5, 2022
Closed
@kpatticha kpatticha added the apm:test-plan-done Pull request that was successfully tested during the test plan label Apr 5, 2022
@kpatticha
Copy link
Contributor

opened a bug #129445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpatticha kpatticha

Labels
apm:test-plan-done Pull request that was successfully tested during the test plan apm:ux-refresh Team:APM All issues that need APM UI Team support v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Use SuggestionsSelect in settings kpatticha/kibana
5 participants
@smith @dannycroft @sorenlouv @kpatticha @elasticmachine