Fix and re-enable Vega test to be consistent with development/CI #110971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DianaDerevyankina
added
Feature:Vega
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
alexwizp
reviewed
Sep 7, 2021
| @@ -116,7 +116,7 @@ describe('VegaVisualizations', () => { | |||
| }); | |||
|
|
|||
| // SKIP: https://github.com/elastic/kibana/issues/83385 | |||
There was a problem hiding this comment.
think skip comment should be removed
alexwizp
reviewed
Sep 7, 2021
| @@ -83,7 +83,7 @@ describe('VegaVisualizations', () => { | |||
| }); | |||
|
|
|||
| // SKIP: https://github.com/elastic/kibana/issues/83385 | |||
|
@elasticmachine merge upstream |
|
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
stratoula
approved these changes
Sep 15, 2021
DianaDerevyankina
added a commit
to DianaDerevyankina/kibana
that referenced
this pull request
Sep 16, 2021
…stic#110971) * Fix and re-enable Vega test to be consistent with development/CI * Remove skip comments Co-authored-by: Kibana Machine <[email protected]>
DianaDerevyankina
added a commit
that referenced
this pull request
Sep 16, 2021
…0971) (#112384) * Fix and re-enable Vega test to be consistent with development/CI * Remove skip comments Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83385
Summary
Updated and re-enabled
vega_visualization.test.js.Checklist
For maintainers