Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and re-enable Vega test to be consistent with development/CI #83385

Closed
tylersmalley opened this issue Nov 14, 2020 · 3 comments · Fixed by #110971
Closed

Fix and re-enable Vega test to be consistent with development/CI #83385

tylersmalley opened this issue Nov 14, 2020 · 3 comments · Fixed by #110971
Assignees
Labels
Feature:Vega Vega visualizations skipped-test Team:Visualizations Visualization editors, elastic-charts and infrastructure :VisEditors:fix-it-week

Comments

@tylersmalley
Copy link
Contributor

These tests were marked as may fail in dev env which is something we must avoid. Additionally, we have started to see them fail in CI due to the day being off by one which is what ultimately resulted in skipping the tests.

10:28:06  Summary of all failing tests
10:28:06   FAIL  ../../plugins/vis_type_vega/public/vega_visualization.test.js
10:28:06    ● VegaVisualizations › VegaVisualization - basics › should show vegalite graph and update on resize (may fail in dev env)
10:28:06  
10:28:06      expect(received).toMatchSnapshot()
10:28:06  
10:28:06      Snapshot name: `VegaVisualizations VegaVisualization - basics should show vegalite graph and update on resize (may fail in dev env) 1`
10:28:06  
10:28:06      Snapshot: "<ul class=\"vgaVis__messages\"><li class=\"vgaVis__message vgaVis__message--warn\"><pre class=\"vgaVis__messageCode\">\"width\" and \"height\" params are ignored because \"autosize\" is enabled. Set \"autosize\": \"none\" to disable</pre></li></ul><div class=\"vgaVis__view\" style=\"height: 100%; cursor: default;\" role=\"graphics-document\" aria-roledescription=\"visualization\" aria-label=\"Vega visualization\"><svg xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\" version=\"1.1\" class=\"marks\" width=\"0\" height=\"0\" viewBox=\"0 0 0 0\" style=\"background-color: transparent;\"><g fill=\"none\" stroke-miterlimit=\"10\" transform=\"translate(7,7)\"><g class=\"mark-group role-frame root\" role=\"graphics-object\" aria-roledescription=\"group mark container\"><g transform=\"translate(0,0)\"><path class=\"background\" aria-hidden=\"true\" d=\"M0.5,0.5h0v0h0Z\" fill=\"transparent\" stroke=\"#ddd\"></path><g><g class=\"mark-line role-mark marks\" role=\"graphics-object\" aria-roledescription=\"line mark container\"><path aria-label=\"key: Dec 10, 2017; doc_count: 0\" role=\"graphics-symbol\" aria-roledescription=\"line mark\" d=\"M0,0L0,0L0,0L0,0L0,0L0,0L0,0L0,0L0,0L0,0\" stroke=\"#54B399\" stroke-width=\"2\"></path></g></g><path class=\"foreground\" aria-hidden=\"true\" d=\"\" display=\"none\"></path></g></g></g></svg></div><div class=\"vgaVis__controls vgaVis__controls--column\"></div>"
10:28:06      Received: "<ul class=\"vgaVis__messages\"><li class=\"vgaVis__message vgaVis__message--warn\"><pre class=\"vgaVis__messageCode\">\"width\" and \"height\" params are ignored because \"autosize\" is enabled. Set \"autosize\": \"none\" to disable</pre></li></ul><div class=\"vgaVis__view\" style=\"height: 100%; cursor: default;\" role=\"graphics-document\" aria-roledescription=\"visualization\" aria-label=\"Vega visualization\"><svg xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\" version=\"1.1\" class=\"marks\" width=\"0\" height=\"0\" viewBox=\"0 0 0 0\" style=\"background-color: transparent;\"><g fill=\"none\" stroke-miterlimit=\"10\" transform=\"translate(7,7)\"><g class=\"mark-group role-frame root\" role=\"graphics-object\" aria-roledescription=\"group mark container\"><g transform=\"translate(0,0)\"><path class=\"background\" aria-hidden=\"true\" d=\"M0.5,0.5h0v0h0Z\" fill=\"transparent\" stroke=\"#ddd\"></path><g><g class=\"mark-line role-mark marks\" role=\"graphics-object\" aria-roledescription=\"line mark container\"><path aria-label=\"key: Dec 11, 2017; doc_count: 0\" role=\"graphics-symbol\" aria-roledescription=\"line mark\" d=\"M0,0L0,0L0,0L0,0L0,0L0,0L0,0L0,0L0,0L0,0\" stroke=\"#54B399\" stroke-width=\"2\"></path></g></g><path class=\"foreground\" aria-hidden=\"true\" d=\"\" display=\"none\"></path></g></g></g></svg></div><div class=\"vgaVis__controls vgaVis__controls--column\"></div>"

key: Dec 10, 2017 vs key: Dec 11, 2017

@tylersmalley tylersmalley added Team:Visualizations Visualization editors, elastic-charts and infrastructure skipped-test labels Nov 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

tylersmalley pushed a commit that referenced this issue Nov 14, 2020
#83385

Signed-off-by: Tyler Smalley <[email protected]>
tylersmalley pushed a commit that referenced this issue Nov 14, 2020
#83385

Signed-off-by: Tyler Smalley <[email protected]>
@tylersmalley
Copy link
Contributor Author

Skipped test:

master: bd08439
7.x/7.11: afa0bed

@alexwizp
Copy link
Contributor

@dziyanadzeraviankina assigned to you, but please wait till #82280 will be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Vega Vega visualizations skipped-test Team:Visualizations Visualization editors, elastic-charts and infrastructure :VisEditors:fix-it-week
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants