Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and re-enable Vega test to be consistent with development/CI #110971

Merged
merged 8 commits into from
Sep 16, 2021
Merged

Fix and re-enable Vega test to be consistent with development/CI #110971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d2144ed
Fix and re-enable Vega test to be consistent with development/CI
DianaDerevyankina Sep 2, 2021
dbb9eed
Merge branch 'master' into issues/83385
kibanamachine Sep 2, 2021
239e268
Merge branch 'master' into issues/83385
kibanamachine Sep 2, 2021
bb464b4
Merge branch 'master' into issues/83385
kibanamachine Sep 3, 2021
7cd180c
Merge branch 'master' into issues/83385
DianaDerevyankina Sep 6, 2021
8688511
Merge branch 'master' into issues/83385
DianaDerevyankina Sep 14, 2021
35fb6d6
Remove skip comments
DianaDerevyankina Sep 14, 2021
7de7c05
Merge branch 'master' into issues/83385
kibanamachine Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/plugins/vis_types/vega/public/__snapshots__/vega_visualization.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 3 additions & 6 deletions src/plugins/vis_types/vega/public/vega_visualization.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,7 @@ describe('VegaVisualizations', () => {
mockWidth.mockRestore();
mockHeight.mockRestore();
});

// SKIP: https://github.com/elastic/kibana/issues/83385
test.skip('should show vegalite graph and update on resize (may fail in dev env)', async () => {
test('should show vegalite graph and update on resize (may fail in dev env)', async () => {
let vegaVis;
try {
vegaVis = new VegaVisualization(domNode, jest.fn());
Expand All @@ -105,7 +103,7 @@ describe('VegaVisualizations', () => {
expect(domNode.innerHTML).toMatchSnapshot();

mockedWidthValue = 256;
mockedHeightValue = 256;
mockedHeightValue = 250;

await vegaVis.vegaView.resize();

Expand All @@ -115,8 +113,7 @@ describe('VegaVisualizations', () => {
}
});

// SKIP: https://github.com/elastic/kibana/issues/83385
test.skip('should show vega graph (may fail in dev env)', async () => {
test('should show vega graph (may fail in dev env)', async () => {
let vegaVis;
try {
vegaVis = new VegaVisualization(domNode, jest.fn());
Expand Down