Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security solutions][Endpoint] Don't allow save event filter with a white space name #101599

Merged
merged 1 commit into from
Jun 9, 2021
Merged

[Security solutions][Endpoint] Don't allow save event filter with a white space name #101599

merged 1 commit into from
Jun 9, 2021

Conversation

dasansol92
Copy link
Contributor

Summary

  • Don't allow save event filter with a white space name. It adds a trim before store name on store
  • Also adds unit test.

event filter name error when white space

For maintainers

@dasansol92 dasansol92 added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 8, 2021
@dasansol92 dasansol92 mentioned this pull request Jun 8, 2021
Closed
@dasansol92 dasansol92 marked this pull request as ready for review June 8, 2021 15:27
@dasansol92 dasansol92 requested a review from a team as a code owner June 8, 2021 15:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.9MB 6.9MB +23.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

paul-tavares
paul-tavares approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had only one question about when to actually show the error, but the changes look good.

...ugins/security_solution/public/management/pages/event_filters/view/components/form/index.tsx
@@ -90,11 +90,12 @@ export const EventFiltersForm: React.FC<EventFiltersFormProps> = memo(
const handleOnChangeName = useCallback(
(e: React.ChangeEvent<HTMLInputElement>) => {
if (!exception) return;
const name = e.target.value.toString().trim();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed from the GIF that when the flyout opens, the name field is already marked as "error". Not sure if that was like that before - if so, then please disregard. but (at least with TA) we tried to ensure we don't light up the form with errors until the user has had a chance to "visit" the field. So we only show errors for a given field after they have left that field (.blur() event).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! This is fixed here: #101563 -> https://github.com/elastic/kibana/pull/101563/files#diff-c8d2872401b39102ce1b83c8750bee6a23e3a78d7fc5a6f52fe02b08520ae603R159

@dasansol92 dasansol92 merged commit d90285f into elastic:master Jun 9, 2021
@kibanamachine kibanamachine mentioned this pull request Jun 9, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 9, 2021
@dasansol92 @kibanamachine
Blocks save event filter with a white space name (elastic#101599)
f798bb0
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 9, 2021
@kibanamachine @dasansol92
Blocks save event filter with a white space name (#101599) (#101738)
5abfeca 
Co-authored-by: David Sánchez <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 9, 2021
@gmmorris
Merge branch 'master' into task-manager/capacity-estimation
53e584b 
* master:
  clarify which parts of TM are experimental (elastic#101757)
  Add sh scripts with _bulk_action route usage examples (elastic#101736)
  [Uptime] Only register route in side nav if uptime show capability is true (elastic#101709)
  Use KIBANA_DOCS in doc link service (elastic#101667)
  [Alerting][Event log] Persisting duration information for active alerts in event log (elastic#101387)
  Address design issues in Discover/Graph (elastic#101584)
  Optimize performance for document table (elastic#101715)
  Change file data visualizer links to point to new location in home application (elastic#101393)
  [Fleet] Tighten policy permissions, take II (elastic#97366)
  [ML] Add debounce to the severity control update  (elastic#101581)
  [Fleet] Fix routing issues with `getPath` and `history.push` (elastic#101658)
  [APM] Add link-to/transaction route (elastic#101731)
  [Index Patterns] Runtime fields CRUD REST API  (elastic#101164)
  [ILM] Refactor types and fix missing aria labels (elastic#101518)
  [Lens] New summary row feature for datatable (elastic#101075)
  Blocks save event filter with a white space name (elastic#101599)
  Improve security server types (elastic#101661)
  [APM] Replace side nav with tabs on Settings page (elastic#101460)
  [APM] Only register items in side nav if user has permissions to see app (elastic#101707)
  [Security solution][Endpoint] Add back button when to the event filters list (elastic#101280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-tavares paul-tavares paul-tavares approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dasansol92 @elasticmachine @kibanamachine @paul-tavares