Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address design issues in Discover/Graph #101584

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Jun 8, 2021

Summary

Addresses the Kibana app part of #98827 to fix some minor design issues and one bug in Graph:

  • Discover panel now no longer has a cut-off shadow. As per suggestion disabled the shadow on the panel.
  • Graph now has the kbnAppWrapper class on it's listing directive, thus making sure the page is correctly full screen.
  • Going to graph without an index pattern, will no longer crash the page.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@timroes timroes added auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0 labels Jun 8, 2021
@timroes timroes changed the title Address design issues in discover/graph Address design issues in Discover/graph Jun 8, 2021
@timroes timroes changed the title Address design issues in Discover/graph Address design issues in Discover/Graph Jun 8, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 426.4KB 426.4KB +13.0B
graph 1.1MB 1.1MB -3.0B
total +10.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@timroes timroes marked this pull request as ready for review June 8, 2021 14:48
@timroes timroes requested a review from a team June 8, 2021 14:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes requested review from cchaos, kertal and majagrubic June 8, 2021 14:49
@timroes timroes added the release_note:skip Skip the PR/issue when compiling release notes label Jun 8, 2021
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graph changes LGTM

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM in Discover, no shadow in Safari, Firefox, Chrome

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timroes for addressing these! Looks much better!

@timroes timroes merged commit ee0efab into elastic:master Jun 9, 2021
@timroes timroes deleted the discover/design-fixes branch June 9, 2021 15:03
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 9, 2021
* Remove Discover panel shadow

* Fix graph issues
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 9, 2021
* Remove Discover panel shadow

* Fix graph issues

Co-authored-by: Tim Roes <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 9, 2021
* master:
  clarify which parts of TM are experimental (elastic#101757)
  Add sh scripts with _bulk_action route usage examples (elastic#101736)
  [Uptime] Only register route in side nav if uptime show capability is true (elastic#101709)
  Use KIBANA_DOCS in doc link service (elastic#101667)
  [Alerting][Event log] Persisting duration information for active alerts in event log (elastic#101387)
  Address design issues in Discover/Graph (elastic#101584)
  Optimize performance for document table (elastic#101715)
  Change file data visualizer links to point to new location in home application (elastic#101393)
  [Fleet] Tighten policy permissions, take II (elastic#97366)
  [ML] Add debounce to the severity control update  (elastic#101581)
  [Fleet] Fix routing issues with `getPath` and `history.push` (elastic#101658)
  [APM] Add link-to/transaction route (elastic#101731)
  [Index Patterns] Runtime fields CRUD REST API  (elastic#101164)
  [ILM] Refactor types and fix missing aria labels (elastic#101518)
  [Lens] New summary row feature for datatable (elastic#101075)
  Blocks save event filter with a white space name (elastic#101599)
  Improve security server types (elastic#101661)
  [APM] Replace side nav with tabs on Settings page (elastic#101460)
  [APM] Only register items in side nav if user has permissions to see app (elastic#101707)
  [Security solution][Endpoint] Add back button when to the event filters list (elastic#101280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application Feature:Graph Graph application feature release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants