Blocks save event filter with a white space name

elastic · Jun 8, 2021 · 3c9226c · 3c9226c
1 parent c1924c3
commit 3c9226c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/...curity_solution/public/management/pages/event_filters/view/components/form/index.test.tsx b/...curity_solution/public/management/pages/event_filters/view/components/form/index.test.tsx
@@ -102,6 +102,23 @@ describe('Event filter form', () => {
     expect(store.getState()!.management!.eventFilters!.form!.hasNameError).toBeFalsy();
   });
 
+  it('should change name with a white space still shows an error', async () => {
+    component = renderComponentWithdata();
+
+    const nameInput = component.getByPlaceholderText(NAME_PLACEHOLDER);
+
+    act(() => {
+      fireEvent.change(nameInput, {
+        target: {
+          value: ' ',
+        },
+      });
+    });
+
+    expect(store.getState()!.management!.eventFilters!.form!.entry!.name).toBe('');
+    expect(store.getState()!.management!.eventFilters!.form!.hasNameError).toBeTruthy();
+  });
+
   it('should change comments', async () => {
     component = renderComponentWithdata();
 

diff --git a/...ns/security_solution/public/management/pages/event_filters/view/components/form/index.tsx b/...ns/security_solution/public/management/pages/event_filters/view/components/form/index.tsx
@@ -90,11 +90,12 @@ export const EventFiltersForm: React.FC<EventFiltersFormProps> = memo(
     const handleOnChangeName = useCallback(
       (e: React.ChangeEvent<HTMLInputElement>) => {
         if (!exception) return;
+        const name = e.target.value.toString().trim();
         dispatch({
           type: 'eventFiltersChangeForm',
           payload: {
-            entry: { ...exception, name: e.target.value.toString() },
-            hasNameError: !e.target.value,
+            entry: { ...exception, name },
+            hasNameError: !name,
           },
         });
       },