Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Re-add support for configuring server.host: "0" #100551

Merged
merged 1 commit into from
May 26, 2021
Merged

[7.x] Re-add support for configuring server.host: "0" #100551

merged 1 commit into from
May 26, 2021

Conversation

watson
Copy link
Contributor

@watson watson commented May 25, 2021

Support for this was lost in #100378.

This was discovered by @mdelapenya in elastic/e2e-testing#1195.

@watson watson added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v7.14.0 labels May 25, 2021
@watson watson requested a review from a team May 25, 2021 13:46
@watson watson self-assigned this May 25, 2021
@watson watson mentioned this pull request May 25, 2021
Merged
9 tasks
@watson watson changed the title Re-add support for configuring server.host: "0" [7.x] Re-add support for configuring server.host: "0" May 25, 2021
pgayvallet
pgayvallet approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@pgayvallet pgayvallet mentioned this pull request May 25, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @watson

@watson watson merged commit 3088c70 into elastic:7.x May 26, 2021
@watson watson deleted the fix-server-host branch May 26, 2021 08:14
@pgayvallet pgayvallet mentioned this pull request May 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

@mdelapenya mdelapenya mdelapenya approved these changes

Assignees

@watson watson

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@watson @kibanamachine @mdelapenya @pgayvallet