Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

fix: use proper format for kibana's server host #1195

Merged
merged 1 commit into from
May 24, 2021

Conversation

mdelapenya
Copy link
Contributor

@mdelapenya mdelapenya commented May 24, 2021

What does this PR do?

It uses a proper format for the value of kibana's server host, matching that value with other maintenance branches (master, 7.13, 7.12, 7.11)

Why is it important?

Kibana cannot start, therefore the runtime dependencies for the tests are not satisfied, causing the entire test suite to fail.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests for the CLI, and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Author's Checklist

Related issues

@mdelapenya mdelapenya self-assigned this May 24, 2021
@mdelapenya mdelapenya requested a review from a team May 24, 2021 09:10
@mdelapenya mdelapenya marked this pull request as ready for review May 24, 2021 09:12
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1195 opened

  • Start Time: 2021-05-24T09:10:27.955+0000

  • Duration: 23 min 34 sec

  • Commit: 24513cd

Test stats 🧪

Test Results
Failed 0
Passed 160
Skipped 0
Total 160

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 160
Skipped 0
Total 160

@mdelapenya
Copy link
Contributor Author

@watson are you aware of a change in 7.x about this issue? I remember a warning was added in elastic/kibana#87471, but since friday, the 7.x kibana build is not able to start because of the server host issue. Please see log error in #1194. I'd appreciate if you are able to point me to the possible change, as I haven't been able to find it yet.

@mdelapenya mdelapenya merged commit 68543cc into elastic:7.x May 24, 2021
@watson
Copy link

watson commented May 25, 2021

Hmm 7.x should still support using 0 as the server.host, just outputting a deprecation warning. Support for using just 0 seems to have been removed in elastic/kibana#100378. Last time this was discussed this was considered a breaking change, so I assume it's accidental. ping @elastic/kibana-core

@watson
Copy link

watson commented May 25, 2021

I've created a PR to fix this: elastic/kibana#100551 - hopefully the tests pass and core agrees this is the way to go.

@mdelapenya
Copy link
Contributor Author

Thanks! We will revert this commit to represent the current state of 7.x in Kibana.

@pgayvallet
Copy link

Support for using just 0 seems to have been removed in elastic/kibana#100378.

Not sure how I did mess up that backport, but that was a mistake, yes. 0 should still be supported on 7.x. Thanks for elastic/kibana#100551.

@watson
Copy link

watson commented May 26, 2021

@mdelapenya I've merged the fix into 7.x now. Thanks for spotting this 👍

@mdelapenya mdelapenya deleted the fix-kibana-server-host branch June 2, 2021 05:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants