-
Notifications
You must be signed in to change notification settings - Fork 42
fix: use proper format for kibana's server host #1195
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
@watson are you aware of a change in 7.x about this issue? I remember a warning was added in elastic/kibana#87471, but since friday, the 7.x kibana build is not able to start because of the server host issue. Please see log error in #1194. I'd appreciate if you are able to point me to the possible change, as I haven't been able to find it yet. |
Hmm |
I've created a PR to fix this: elastic/kibana#100551 - hopefully the tests pass and core agrees this is the way to go. |
Thanks! We will revert this commit to represent the current state of 7.x in Kibana. |
Not sure how I did mess up that backport, but that was a mistake, yes. |
@mdelapenya I've merged the fix into |
What does this PR do?
It uses a proper format for the value of kibana's server host, matching that value with other maintenance branches (master, 7.13, 7.12, 7.11)
Why is it important?
Kibana cannot start, therefore the runtime dependencies for the tests are not satisfied, causing the entire test suite to fail.
Checklist
make notice
in the proper directory)Author's Checklist
Related issues