-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/drag_and_drop·ts - lens app lens drag and drop tests should move the column to compatible dimension group #84941
Comments
Pinging @elastic/kibana-app (Team:KibanaApp) |
* master: (28 commits) [Actions] fixes bug where severity is auto selected but not applied to the action in PagerDuty (elastic#84891) Only attempt to rollover signals index if version < builtin version (elastic#84982) skip flaky suite (elastic#84978) skip lens rollup tests Add geo containment tracking alert type (elastic#84151) Changed rollup tests to use test user rather than elastic super user. (elastic#79567) skip 'should allow creation of lens xy chart' elastic#84957 [APM] Add log_level/sanitize_field_names config options to Python Agent (elastic#84810) [Maps] geo line source (elastic#76572) [data.search] Move search method inside session service and add tests (elastic#84715) skip lens drag and drop test. elastic#84941 [Ingest Node Pipelines] Integrate painless autocomplete (elastic#84554) [Lens] allow drag and drop reorder on xyChart for y dimension (elastic#84640) [Lens] Fix error when selecting the current field again (elastic#84817) [Metrics UI] Add metadata tab to node details flyout (elastic#84454) [CI] Enables APM collection (elastic#81731) [Workplace Search] Migrate Sources Schema tree (elastic#84847) Disable checking for conflicts when copying saved objects (elastic#83575) [SECURITY_SOLUTION] delete advanced Policy fields when they are empty (elastic#84368) y18n 4.0.0 -> 4.0.1 (elastic#84905) ...
New failure: Jenkins Build |
Two failures, one in 7.x and one in a PR to 7.11 since this was fixed. Do you have a chance to look at this again @flash1293? |
Seems like this can still happen: I checked the code and I realized we are doing this to simulate dragging:
@wylieconlon Do you think it's possible the 50ms just haven't passed yet and the drag is not completed but still in progress? Or maybe the other way around, the drop event came in too early and couldn't be processed? I will prepare a PR increasing the waiting times a bit here but I think we have to test it "in the wild" by merging into master because this issue is pretty rare (happened 3 times in 30days, so flaky test runner would need a lot of cycles to rule it out). |
@flash1293 It does seem possible that 50ms is not enough to execute a state update, since a state update is needed to mark that the drag has started. Specifically we use this code on start:
So we probably have some underlying performance issues here, but I agree that increasing the timeout is a solution that would help. |
A test failed on a tracked branch
First failure: Jenkins Build
The text was updated successfully, but these errors were encountered: