Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Make drag drop test more stable #88614

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

flash1293
Copy link
Contributor

Fixes #84941 by giving more time to complete drag/drop operations

@flash1293 flash1293 added 8.0.0 Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0 labels Jan 18, 2021
@flash1293 flash1293 marked this pull request as ready for review January 19, 2021 08:16
@flash1293 flash1293 requested a review from a team as a code owner January 19, 2021 08:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run the functional test, but it does look safe to make this change and watch the results coming in. Left a style comment.

`,
from,
to
);
// wait for 150ms to make sure the script has run
await delay(150);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not using PageObjects.common.sleep?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to avoid introducing this dependency as the browser service is very basic (not even sure whether it work because the common page object relies on the browser service itself).

@wylieconlon wylieconlon added v8.0.0 and removed 8.0.0 labels Jan 20, 2021
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flash1293 flash1293 merged commit 0b798f7 into elastic:master Jan 21, 2021
flash1293 added a commit to flash1293/kibana that referenced this pull request Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0 v8.0.0
Projects
None yet
5 participants