-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Fix functional test failures #84979
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
I'm not sure how this is improving the situation - looks like it is retrying the click if it failed but I don't think the close click is failing, it's the flyout re-rendering too slowly. So the click works and react re-renders but by the time the test tries to click the next element, the flyout is still open and the next element is shadowed. I suggest clicking the close button, then waiting for it to disappear (and optionally wrapping that into a retry) |
@flash1293 Yes, that approach is what I'm doing now. This now waits to verify that the panel has closed. I also removed the field cache from the rollup index pattern. |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, will merge on green build
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
Two tests started failing to close the dimension editor panel. I believe that there is an issue successfully clicking icon buttons, which was a change that @mbondyra recently made to keep it accessible. The retry now verifies that the panel closes.
Fixes #84941, Fixes #84957, Fixes #84978