Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/persisted_state 👉 src/plugins/visualizations #46926

Closed
8 tasks
streamich opened this issue Sep 30, 2019 · 1 comment
Closed
8 tasks

ui/persisted_state 👉 src/plugins/visualizations #46926

streamich opened this issue Sep 30, 2019 · 1 comment
Assignees
@alexwizp
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available)

Comments

@streamich
Copy link
Contributor

streamich commented Sep 30, 2019 •
edited by Dosant
Loading

  • ui/persisted_state 👉 src/plugins/visualizations (1 week)
    • Problems with Angular digest cycles, talk with @lizozom
    • BaseObject
      • Inline angular.toJson function, example, see source.
      • Move to src/plugins/visualizations
    • SimpleEmitter and createLegacyClass() 👉 src/plugins/kibana_utils
    • PersistedState
      • Inline PersistedStateError class.
      • Move to src/plugins/visualizations

Parent issue: #50897
@streamich streamich added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:AppArch labels Sep 30, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

This was referenced Sep 30, 2019
Closed
Closed
This was referenced Feb 6, 2020
Closed
Merged
@ppisljar ppisljar mentioned this issue Feb 20, 2020
Closed
11 tasks
@alexwizp alexwizp self-assigned this Feb 21, 2020
alexwizp added a commit to alexwizp/kibana that referenced this issue Feb 24, 2020
@alexwizp
ui/persisted_state 👉 src/plugins/visualizations
9b75f81 
Part of elastic#46926
@alexwizp alexwizp mentioned this issue Feb 24, 2020
Merged
9 tasks
@ppisljar ppisljar removed their assignment Feb 24, 2020
@alexwizp alexwizp mentioned this issue Feb 25, 2020
Merged
10 tasks
alexwizp added a commit that referenced this issue Feb 27, 2020
@alexwizp @elasticmachine
[Step 1] ui/persisted_state 👉 src/plugins/visualizations (#58324)
7fdff34 
* ui/persisted_state 👉 src/plugins/visualizations

Part of #46926

* fix JEST

* remove sinon from tests

Co-authored-by: Elastic Machine <[email protected]>
alexwizp added a commit to alexwizp/kibana that referenced this issue Feb 27, 2020
@alexwizp @elasticmachine
[Step 1] ui/persisted_state 👉 src/plugins/visualizations (elastic#58324)
f2d603b 
* ui/persisted_state 👉 src/plugins/visualizations

Part of elastic#46926

* fix JEST

* remove sinon from tests

Co-authored-by: Elastic Machine <[email protected]>
alexwizp added a commit that referenced this issue Feb 27, 2020
@alexwizp @elasticmachine
[Step 1] ui/persisted_state 👉 src/plugins/visualizations (#58324) (#5…
6d23892 
…8698)

* ui/persisted_state 👉 src/plugins/visualizations

Part of #46926

* fix JEST

* remove sinon from tests

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lizozom @streamich @ppisljar @elasticmachine @alexwizp