Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Step 1] ui/persisted_state 👉 src/plugins/visualizations #58324

Merged
merged 8 commits into from
Feb 27, 2020

Conversation

alexwizp
Copy link
Contributor

Part of #46926

Summary

  • Remove AngularJS PersistedState
  • Mocha -> Jest (persisted_state_provider.test.ts)

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@elastic elastic deleted a comment from kibanamachine Feb 24, 2020
@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Feb 24, 2020
@elastic elastic deleted a comment from kibanamachine Feb 24, 2020
@alexwizp alexwizp self-assigned this Feb 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@alexwizp alexwizp added Feature:NP Migration v7.7.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Feb 24, 2020
@alexwizp alexwizp marked this pull request as ready for review February 24, 2020 17:00
@alexwizp alexwizp requested review from a team February 24, 2020 17:00
@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@kertal kertal self-requested a review February 24, 2020 17:37
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, nice cleanup 👍 ! Together with #58352 and #57175 this will remove all legacy state of Visualize and Discover. Tested locally in chrome.

@alexwizp
Copy link
Contributor Author

ping @elastic/stack-monitoring-ui

@alexwizp
Copy link
Contributor Author

alexwizp commented Feb 25, 2020

@simianhacker @igoristic @jasonrhodes @sgrodzicki could you please have a look? I need a review from the stack-monitoring-ui group

@alexwizp alexwizp changed the title ui/persisted_state 👉 src/plugins/visualizations [Step 1] ui/persisted_state 👉 src/plugins/visualizations Feb 25, 2020
@alexwizp
Copy link
Contributor Author

alexwizp commented Feb 26, 2020

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Stack Monitoring. Looks good 👍

# Conflicts:
#	src/legacy/core_plugins/kibana/public/visualize/np_ready/application.ts
#	x-pack/legacy/plugins/monitoring/public/np_imports/angular/modules.ts
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit 7fdff34 into elastic:master Feb 27, 2020
alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 27, 2020
* ui/persisted_state 👉 src/plugins/visualizations

Part of elastic#46926

* fix JEST

* remove sinon from tests

Co-authored-by: Elastic Machine <[email protected]>
alexwizp added a commit that referenced this pull request Feb 27, 2020
…8698)

* ui/persisted_state 👉 src/plugins/visualizations

Part of #46926

* fix JEST

* remove sinon from tests

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants