-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Step 1] ui/persisted_state 👉 src/plugins/visualizations #58324
Conversation
@elasticmachine merge upstream |
Pinging @elastic/kibana-app-arch (Team:AppArch) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @elastic/stack-monitoring-ui |
@simianhacker @igoristic @jasonrhodes @sgrodzicki could you please have a look? I need a review from the stack-monitoring-ui group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with Stack Monitoring. Looks good 👍
# Conflicts: # src/legacy/core_plugins/kibana/public/visualize/np_ready/application.ts # x-pack/legacy/plugins/monitoring/public/np_imports/angular/modules.ts
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* ui/persisted_state 👉 src/plugins/visualizations Part of elastic#46926 * fix JEST * remove sinon from tests Co-authored-by: Elastic Machine <[email protected]>
…8698) * ui/persisted_state 👉 src/plugins/visualizations Part of #46926 * fix JEST * remove sinon from tests Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Part of #46926
Summary
persisted_state_provider.test.ts
)Checklist
Delete any items that are not applicable to this PR.
For maintainers