Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agg_types: Remove legacy dependencies #56934

Closed
34 tasks done
lukeelmers opened this issue Feb 5, 2020 · 1 comment · Fixed by #57064
Closed
34 tasks done

agg_types: Remove legacy dependencies #56934

lukeelmers opened this issue Feb 5, 2020 · 1 comment · Fixed by #57064
Assignees
@lukeelmers
Labels
Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:NP Migration

Comments

@lukeelmers
Copy link
Member

lukeelmers commented Feb 5, 2020 •
edited
Loading

Part of #42639

Need to finish removing legacy dependencies from ui/agg_types, which now live in the shim data plugin in src/legacy/core_plugins/data/public/search/aggs:

  • clean up imports
  • date_histogram
    • timefilter - cut over to np service, just used in setBounds
    • chrome.getUiSettingsClient
  • date_range
    • field formats
    • uiSettings
  • filters
  • geo_hash
  • histogram
    • ui/notify
  • ip range
    • field formats
  • cardinality
    • field formats
  • count
    • field formats
  • metric_agg_type
    • field formats
  • percentile_ranks
    • field formats
  • cut over to using service getter/setter for stateful dependencies consumed by agg types
  • clean up runtime contract
  • move legacy runtime items to __LEGACY
  • add createAggConfigs function to remove the need for folks importing AggConfigs
  • turn agg types into a registry, register default items, and expose in lifecycle contract
  • unit tests for agg types registry
  • update AggConfigs & AggConfig to accept types registry in the constructor
  • finish mocks so tests are fixed
  • move AggConfig, AggConfigs tests from ui/vis/__tests__
@lukeelmers lukeelmers added Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Team:AppArch Feature:NP Migration labels Feb 5, 2020
@lukeelmers lukeelmers self-assigned this Feb 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

This was referenced Feb 5, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukeelmers lukeelmers

Labels
Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:NP Migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prep agg types for new platform lukeelmers/kibana
2 participants
@lukeelmers @elasticmachine