Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Show http url in the Span details #20145

Closed
hmdhk opened this issue Jun 22, 2018 · 11 comments
Closed

[APM] Show http url in the Span details #20145

hmdhk opened this issue Jun 22, 2018 · 11 comments
Assignees
Labels
Team:APM All issues that need APM UI Team support v6.6.0

Comments

@hmdhk
Copy link

hmdhk commented Jun 22, 2018

Background

The information is stored in the span context and merged in elastic/apm-server#1037

Please note that this is the full url therefore it might be long.

An example of the context:

{
  "context": {
    "http": {
      "url": "http://example.com"
    }
  }
}

Design

03b dt - transaction - span flyout - http url detail

@hmdhk hmdhk added the Team:APM All issues that need APM UI Team support label Jun 22, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@formgeist
Copy link
Contributor

@elastic/apm-agent-devs Quick question; is this something that is applicable for all agents (not only RUM) to show the URL for spans (when available) in the Span details view?

@axw
Copy link
Member

axw commented Aug 21, 2018

Yes, I think so. I've just recently added it to the Go agent: elastic/apm-agent-go#172.

@felixbarny
Copy link
Member

The Java agent does not use that field yet, but we'll also add it.

@formgeist formgeist added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. [zube]: In Design and removed [zube]: Design Ready labels Aug 30, 2018
@formgeist
Copy link
Contributor

I've made a design proposal for adding it to the new Span detail flyout (which is included in DT).

03 dt - transaction - span flyout

cc @elastic/apm-ui

@beniwohli
Copy link

I think it should have the same prominence in the UI as the SQL query, as the URL is about as important for an external request span as the SQL query is for a DB span. Having both in one span doesn't make much sense anyway.

@formgeist
Copy link
Contributor

@beniwohli OK, thanks for the feedback. I'll update the design to have the URL be more prominent.

@formgeist
Copy link
Contributor

Updated design proposal - moving the URL to its own row and made the URL value bigger

03 dt - transaction - span flyout

@beniwohli
Copy link

@formgeist my suggestion was more to show the URL for an external request span exactly like we show the SQL statement in a DB span. You won't have both, a DB span doesn't have a context.http.url and an external request span won't have a context.db.query (or whatever we decided to call that, can't remember).

I had a quick talk with @watson, and he agrees.

@formgeist
Copy link
Contributor

Alrighty, thanks for the clarification - I've updated the screen to have the HTTP URL in a similar style as the DB Statement. Do we want to call it HTTP URL as a title?

03b dt - transaction - span flyout - http url detail

@beniwohli
Copy link

Awesome, LGTM!

ogupte added a commit to ogupte/kibana that referenced this issue Nov 27, 2018
@zube zube bot reopened this Nov 27, 2018
@ogupte ogupte closed this as completed in 6e06bfb Nov 27, 2018
ogupte added a commit to ogupte/kibana that referenced this issue Nov 27, 2018
ogupte added a commit that referenced this issue Nov 27, 2018
sebelga added a commit that referenced this issue Nov 28, 2018
* [APM] Fix horizontal scrollbar being visible in windows 8.1 (#25988)

* [APM] Changed 'Response Time' to 'Duration' in transactions screens (#25990)

* translate InfraOps visualization component (Part 3) (#25213)

* translate InfraOps visualization component (Part 3 - part of folder components)

* update translation of Infra Ops vizualization component (Part 3)

* update translation of Infra Ops vizualization component (Part 3)

* change some ids and add pluralization

* update Infra Ops Part 3 - change some ids, change some intl.formatMessage() to <FormattedMessage> and directly wrap some classes by injectI18n()

* update Infra-III - add static to displayName

* [i18n] Translate Agg_types(part_3) (#26118)

* Translate agg_types - metrics

* Fix issues

* [ML] Aggregate anomalies table data using configured Kibana timezone (#26192)

* [ML] Aggregate anomalies table data using configured Kibana timezone

* [ML] Move dataFormatTz prop out of controller scope

* [ML] Fix alignment of filter icons in anomalies table (#26253)

* [ML] Fix alignment of filter icons in anomalies table

* [ML] Teak y position of icons in expanded row of table

* translate sample data (#26069)

translate sample data

* [ML] Wrap controller initialization in assertions. (#26265)

- The controller tests introduced in #25382 had a flaw: If a controller initialization would fail and throw an error, that test suite wouldn't be able to clean up any stubs. So tests using the same stubs would report and error because the stubs couldn't be wrapped again.
- This PR wraps every controller initialization inside an assertion and catches those errors properly as part of the test.

* [APM] fixes #20145 by displaying span.context.http.url in the span details flyout (#26238)

* Fix spaces license check (#26270)

## Summary

Allows the public spaces API to work with a gold license

Resolves #26271

* Job Info button in Reporting Listing (#25421)

* Job Info button in Reporting Listing

* use lodash directly

* start of flyout use

* description list in flyout

* capitalize

* undefined guard

* expire info on close

* add jest test

* better at error handling + messaging

* Add description for vis types (#26243)

* [migrations] Throw error if reindex task fails (#26062)

Signed-off-by: Tyler Smalley <[email protected]>

* [Reporting] Better logging for waitForSelector failure (#25762)

* [Reporting] Better logging for waitForSelector failure

* break waitForSelector

* experimental changes

* cleanup/consistency

* fix some test report title strings

* test disable chromium

* roll back test code

* take out non-working phantom changes

* roll back disable chromium test

* allow logger to use curried tags

* temporarily re-do report failure-causing change for test

* replace newline with escaped for single log line

* undo test change

* remove obsolete test

* [kbn/pm] allow packages to define extra paths to clean (#26132)

I noticed some discussion about how kbn clean should probably clear out the `.eslintcache` file, since it doesn't handle changes in related modules (for things like the import plugin) and it would be nice if `yarn kbn clean` took care of the issue. I figured it's not a bad idea, but adding `.eslintcache` directly to `@kbn/pm` felt wrong, so instead I've added another config options that can go in the package.json file, `clean.extraPatterns`. This array of patterns is passed into `del()` so that it can include things like negation.

As the name suggests this doesn't override the initial paths, just adds some extras that will be checked and cleared when `yarn kbn clean` is run.

* [config] fix logging.useUTC deprecation unset (#26053)

* Extend precommit hook script to support git GUI apps (#25883)

* feat(NA): extend support from precommit hook to git GUI apps.

* docs(NA): more descriptive error message.

* [DOCS] Clarify monitoring dependencies (#26229)

* apm: add ECS fields to index pattern (#26214)

* support standard license (#26294)

* [kbn-pm] update build

* [eslint] use disallow license header rule (#26309)

Fixes #26295

There are several places where we have accidentally added new license headers with linters but failed to remove old license headers manually. This prevents that by applying the an inverted version of the license headers rule that removed invalid license headers when files are moved.

* Bump node to 8.14.0 (#26313)

Signed-off-by: Tyler Smalley <[email protected]>

* Watch optimizer cache invalidation  (#24172)

* chore(NA): cherry pick work from spencer on impleting the cache invalidation system and merging it with current master.

* feat(NA): add support for dlls bundle into the cache state invalidation system.

* chore(NA): merge with master.

* feat(NA): first working version for the watch cache.

* feat(NA): added logger, correct cache delete and removed last todos.

* feat(NA): remove some useless features for the time being.

* refact(NA): just pass kibanaHapiServer.log function directly instead of an anonimous function that calls the kibanaHapiServer.log one.

* refact(NA): move everything to async.

* refact(NA): remove dll mentions.

* chore(NA): removed types/mkdirp as we dont use mkdirp into typescript.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support v6.6.0
Projects
None yet
Development

No branches or pull requests

8 participants