module/apmhttp: set client request URL #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the SpanContext.HTTP field, of type HTTPSpanContext. This new type contains a single "url" field, for storing the URL of client-side HTTP requests. We strip out the user:password from the URL, if included.
Add the SetHTTPRequest method to SpanContext, which records the HTTP request URL in the span context.
Modify the client instrumentation to record the URL in the span context.
axw
force-pushed
the
apmhttp-client-http-url
branch
from
5e8eaac to
fc1d1de
Compare
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 74.48% 74.55% +0.06%
==========================================
Files 83 83
Lines 5036 5093 +57
==========================================
+ Hits 3751 3797 +46
- Misses 1102 1108 +6
- Partials 183 188 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the elasticapm package, we introduce a new SpanContext.SetHTTPRequest method which records the URL of an outgoing HTTP request in span context, and later add it to the span model object. Finally we modify the apmhttp client instrumentation to make use of this.
Closes #171