Add context.http.url to spans. #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simitt
force-pushed
the
adapt-span-context
branch
from
9658a6e to
1d492eb
Compare
hmdhk
reviewed
Jun 28, 2018
| @@ -24,16 +24,18 @@ | |||
| "unloadEventEnd": 32, | |||
| "unloadEventStart": 32 | |||
| }, | |||
| "http": { | |||
| "url": { | |||
| "location": "http://localhost:8000/test/e2e/general-usecase/" | |||
There was a problem hiding this comment.
@simitt , This is part of transaction context but the change was about span.context!
hmdhk
reviewed
Jun 28, 2018
testdata/transaction/frontend.json
Outdated
| "location": "http://localhost:8000/test/e2e/general-usecase/" | ||
| "http": { | ||
| "url": { | ||
| "location": "http://localhost:8000/test/e2e/general-usecase/" |
There was a problem hiding this comment.
@simitt , This is also part of transaction context!
There was a problem hiding this comment.
yes sorry, got the wrong one here, will change this, which automatically changes the approved test case.
implements elastic#777
simitt
force-pushed
the
adapt-span-context
branch
from
1d492eb to
6935453
Compare
|
There has been merge conflicts with master in the mean time, so I had to rebase to master, sorry for inconveniences. |
|
jenkins, retest this please. |
jalvz
approved these changes
Jun 28, 2018
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Jul 4, 2018
* Add context.http.url to spans. implements elastic#777
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Jul 4, 2018
* Add context.http.url to spans. implements elastic#777
simitt
added a commit
that referenced
this pull request
Jul 4, 2018
* Add context.http.url to spans. implements #777
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #777
This PR defines
span.context.http.urland stores it in ES, without indexing the field.cc @jahtalab