Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataset quality] Add actions column #170236

Closed
yngrdyn opened this issue Oct 31, 2023 · 5 comments · Fixed by #173272
Closed

[Dataset quality] Add actions column #170236

yngrdyn opened this issue Oct 31, 2023 · 5 comments · Fixed by #173272
Assignees
@yngrdyn
Labels
Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team

Comments

@yngrdyn
Copy link
Contributor

yngrdyn commented Oct 31, 2023 •
edited
Loading

📓 Summary

Allow users to navigate to Log explorer.

image

✔️ Acceptance criteria

  • The datasets health page shows a column dedicated to Actions.
  • Actions column is not sortable
  • Open allows users to navigate back to log Explorer with the Integration > Dataset > namespace selected.
@yngrdyn yngrdyn added Team:obs-ux-logs Observability Logs User Experience Team Feature:Dataset Health labels Oct 31, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@yngrdyn yngrdyn mentioned this issue Nov 3, 2023
Open
@mohamedhamed-ahmed
Copy link
Contributor

@yngrdyn Do we still need the view in dashboard aciton? I guess for first phase we need to filter the actions as per the last design meeting?

@yngrdyn
Copy link
Contributor Author

yngrdyn commented Nov 7, 2023

@yngrdyn Do we still need the view in dashboard aciton?

We are in the process of update the tickets to match the last designs

@yngrdyn yngrdyn changed the title [Dataset health] Add actions column [Dataset quality] Add actions column Nov 9, 2023
@mohamedhamed-ahmed mohamedhamed-ahmed self-assigned this Nov 24, 2023
@mohamedhamed-ahmed
Copy link
Contributor

@yngrdyn for the scope of this ticket do we only display the Open link in the actions column?

@yngrdyn
Copy link
Contributor Author

yngrdyn commented Nov 24, 2023

@yngrdyn for the scope of this ticket do we only display the Open link in the actions column?

that's correct, it will be the only action for now. We can start building more actions in the future

@mohamedhamed-ahmed mohamedhamed-ahmed mentioned this issue Nov 30, 2023
Closed
@yngrdyn yngrdyn self-assigned this Dec 12, 2023
@yngrdyn yngrdyn mentioned this issue Dec 13, 2023
Merged
yngrdyn added a commit that referenced this issue Dec 18, 2023
@yngrdyn @kibanamachine
[Dataset quality] Open in Log explorer action (#173272)
ce293db 
Closes #170236.

### Changes

This PR focuses on adding an action per dataset + namespace to navigate
to Observability log explorer. At the same time I took the opportunity
to update `Open in discover` link to include the controls present in
`Observability Log Explorer` state (atm just `namespace`)

1. Extracted `getRouterLinkProps` to a new package for reusability.
2. New `Actions` column was added to table.
3. `LogExplorerLink ` component was introduced, to reuse the navigation
logic between the table and the flyout.
4. `getDiscoverFiltersFromState` was added to combine state filters and
controls into discover state when navigating to discover

#### Demo


https://github.com/elastic/kibana/assets/1313018/a3f38615-d8ae-432b-ba7b-05a6901f870c

---------

Co-authored-by: kibanamachine <[email protected]>
@yngrdyn yngrdyn mentioned this issue Dec 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yngrdyn yngrdyn

Labels
Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
3 participants
@yngrdyn @mohamedhamed-ahmed @elasticmachine