Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset quality] Update Log Explorer Navigation Links #172159

Closed
mohamedhamed-ahmed opened this issue Nov 29, 2023 · 2 comments
Closed

[Dataset quality] Update Log Explorer Navigation Links #172159

mohamedhamed-ahmed opened this issue Nov 29, 2023 · 2 comments
Labels
Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team

Comments

@mohamedhamed-ahmed
Copy link
Contributor

📓 Summary

At the moment, both log explorer links in the dataset quality table and flyout navigate properly to the log explorer page but with setting the name space filter in the search bar.
We want to make use of the new filter prop in the locators once this PR is merged, so that we set the namespace filter in the curated filter components under the search bar.

❌ Before

Screenshot 2023-11-29 at 13 30 15

✅ After

Screenshot 2023-11-29 at 13 31 20

✔️ Acceptance criteria

  • Both navigation links should navigate to the log explorer with setting the namespace filter in the curated custom filter component

💡 Implementation hint

  • Changes should be done here to make use of the new prop instead of having the query object
@mohamedhamed-ahmed mohamedhamed-ahmed added Team:obs-ux-logs Observability Logs User Experience Team Feature:Dataset Health labels Nov 29, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@yngrdyn
Copy link
Contributor

yngrdyn commented Dec 18, 2023

This was addressed as part of #170236

@yngrdyn yngrdyn closed this as completed Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Development

No branches or pull requests

3 participants