Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard Navigation] Link Editing #161274

Closed
Tracked by #154354
Heenawter opened this issue Jul 5, 2023 · 2 comments · Fixed by #161568
Closed
Tracked by #154354

[Dashboard Navigation] Link Editing #161274

Heenawter opened this issue Jul 5, 2023 · 2 comments · Fixed by #161568
Assignees
@Heenawter
Labels
Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Dashboard Navigation Related to the Dashboard Navigation Project Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

As part of the Dashboard Navigation Initiative, we will need a way to both remove links from the navigation panel and edit existing links - this includes being able to change their destination (external or dashboard-to-dashboard) and label, as well as (once it is added) the order of the links in the container.
@Heenawter Heenawter added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Project:Dashboard Navigation Related to the Dashboard Navigation Project labels Jul 5, 2023
@Heenawter Heenawter self-assigned this Jul 5, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter mentioned this issue Jul 5, 2023
Closed
@Heenawter Heenawter mentioned this issue Jul 5, 2023
Closed
17 tasks
@Heenawter Heenawter added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jul 5, 2023
@Heenawter Heenawter mentioned this issue Jul 10, 2023
Merged
7 tasks
@Heenawter Heenawter linked a pull request Jul 12, 2023 that will close this issue
[Dashboard Navigation] Add link editing + reordering #161568
Merged
7 tasks
@Heenawter Heenawter removed a link to a pull request Jul 12, 2023
[Dashboard Navigation] Add link editing + reordering #161568
Merged
7 tasks
@Heenawter Heenawter linked a pull request Jul 12, 2023 that will close this issue
[Dashboard Navigation] Add link editing + reordering #161568
Merged
7 tasks
Heenawter added a commit that referenced this issue Jul 17, 2023
@Heenawter @kibanamachine
[Dashboard Navigation] Add link editing + reordering (#161568)
c7485e6 
Closes #154361
Closes #161274
Closes #161693

## Summary

This PR adds editing capabilities to the navigation embeddable,
including deleting/editing existing links and reordering the list of
links. It also fixes the delay in opening the editing flyout from the
async import in `getExplicitInput` (from the navigation embeddable
factory) by moving it to the constructor of the factory.



https://github.com/elastic/kibana/assets/8698078/ace9dcd4-0607-40de-959e-94348a5fa4fa



### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ] ~[Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios~ Will be
addressed in #161287
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
@Heenawter
Copy link
Contributor Author

Closed by #161568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Heenawter Heenawter

Labels
Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Dashboard Navigation Related to the Dashboard Navigation Project Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dashboard Navigation] Add link editing + reordering Heenawter/kibana
2 participants
@Heenawter @elasticmachine