Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard Navigation] Link Creation #154360

Closed
Tracked by #154354
ThomThomson opened this issue Apr 4, 2023 · 3 comments · Fixed by #160179
Closed
Tracked by #154354

[Dashboard Navigation] Link Creation #154360

ThomThomson opened this issue Apr 4, 2023 · 3 comments · Fixed by #160179
Assignees
@Heenawter
Labels
Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort Project:Dashboard Navigation Related to the Dashboard Navigation Project Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

ThomThomson commented Apr 4, 2023 •
edited by Heenawter
Loading

Description

As part of the Dashboard Navigation Initiative, we will need a way to create dashboard links. The editor should allow the author to choose which dashboard the link points to, and to set a title for the link (defaults to the dashboard title)
@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Project:Dashboard Navigation Related to the Dashboard Navigation Project labels Apr 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson mentioned this issue Apr 4, 2023
Closed
17 tasks
@Heenawter Heenawter self-assigned this May 15, 2023
@Heenawter Heenawter mentioned this issue May 16, 2023
Closed
9 tasks
@Heenawter Heenawter added loe:large Large Level of Effort and removed loe:medium Medium Level of Effort labels Jun 29, 2023
@Heenawter Heenawter changed the title [Dashboard Navigation] Inline Link Creation & Editing [Dashboard Navigation] Link Creation & Editing Jun 29, 2023
@Heenawter Heenawter changed the title [Dashboard Navigation] Link Creation & Editing [Dashboard Navigation] Link Creation Jul 5, 2023
@Heenawter
Copy link
Contributor

Heenawter commented Jul 5, 2023 •
edited
Loading

Modifying this issue so that it is only about the creation process - the editing process will be addressed in a follow up, since these are both pretty large tasks.

@Heenawter Heenawter added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jul 5, 2023
@Heenawter Heenawter mentioned this issue Jul 5, 2023
Merged
7 tasks
@Heenawter Heenawter linked a pull request Jul 5, 2023 that will close this issue
[Dashboard Navigation] Add creation UI #160179
Merged
7 tasks
Heenawter added a commit that referenced this issue Jul 10, 2023
@Heenawter @kibanamachine
[Dashboard Navigation] Add creation UI (#160179)
3c2e8f6 
Closes #154360

## Summary

This PR adds the first draft of the UI for creating the navigation
embeddable and adding links to it. Note that this PR **only** addresses
adding links - you cannot currently remove links from the panel or edit
existing links. Also, because this PR contains critical code, some
cleanup tasks were left as `TODO` in order to get it merged ASAP - these
will be addressed in follow up PRs.



https://github.com/elastic/kibana/assets/8698078/ac011207-1c4b-40cd-a151-78addb99d32d



### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ] ~[Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios~ Will be
addressed in #161287
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
@Heenawter
Copy link
Contributor

Closed by #160179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Heenawter Heenawter

Labels
Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort Project:Dashboard Navigation Related to the Dashboard Navigation Project Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dashboard Navigation] Add creation UI Heenawter/kibana
3 participants
@Heenawter @ThomThomson @elasticmachine