[Dashboard Navigation] Fix delayed opening of create/edit flyout #161693
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
loe:small
Small Level of Effort
Project:Dashboard Navigation
Related to the Dashboard Navigation Project
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Comments
Heenawter
added
bug
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
This was referenced Jul 11, 2023
Heenawter
added
loe:small
7 tasks
Heenawter
added a commit
that referenced
this issue
Jul 17, 2023
Closes #154361 Closes #161274 Closes #161693 ## Summary This PR adds editing capabilities to the navigation embeddable, including deleting/editing existing links and reordering the list of links. It also fixes the delay in opening the editing flyout from the async import in `getExplicitInput` (from the navigation embeddable factory) by moving it to the constructor of the factory. https://github.com/elastic/kibana/assets/8698078/ace9dcd4-0607-40de-959e-94348a5fa4fa ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] ~[Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~ Will be addressed in #161287 - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
|
Closed by #161568 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug:
When the network is throttled, the navigation embeddable edit flyout is delayed by some sort of async behaviour happening internally - even if we are waiting for something to load, this should not stop the flyout from opening. FYI the image embeddable suffers from the same thing (we don't need to fix this) - so maybe it has something to do with how we are opening the flyout in
getExplicitInput(since we took inspo from the image embeddable for this)? Need to investigateVideo:
Screen.Recording.2023-07-11.at.11.39.08.AM.mov
Notice that the image "pops in" for the empty state even on the second load, most likely because we are importing it in the flyout itself - as part of this, we should probably make it so that this is only loaded/imported a single time.
The text was updated successfully, but these errors were encountered: