Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/infra/hosts_view·ts - InfraOps App Metrics UI Hosts View #Single host Flyout should navigate to APM services after click #159368

Closed
kibanamachine opened this issue Jun 9, 2023 · 10 comments · Fixed by #161244 or #162147
Closed

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/infra/hosts_view·ts - InfraOps App Metrics UI Hosts View #Single host Flyout should navigate to APM services after click #159368

kibanamachine opened this issue Jun 9, 2023 · 10 comments · Fixed by #161244 or #162147
Assignees
@jennypavlova
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 9, 2023 •
edited
Loading

A test failed on a tracked branch

Error: expected 'kuery=host.hostname:"Jennys-MBP.fritz.box"' to contain 'environment=ENVIRONMENT_ALL'
    at Assertion.assert (expect.js:100:11)
    at Assertion.contain (expect.js:442:10)
    at Context.<anonymous> (hosts_view.ts:306:26)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.apply (wrap_function.js:73:16)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jun 9, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 9, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@mistic mistic added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Jun 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 13, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Jun 29, 2023
@mistic
skip flaky suite (#159368, #159369)
5c422a8
@mistic
Copy link
Member

mistic commented Jun 29, 2023

Skipped.

main: 5c422a8

@jennypavlova jennypavlova self-assigned this Jul 5, 2023
@jennypavlova jennypavlova mentioned this issue Jul 5, 2023
Merged
jennypavlova added a commit that referenced this issue Jul 6, 2023
@jennypavlova
[Infra UI] Hosts flyout test fix (#161244)
9d57196 
Closes #159368 

## Summary

I saw that the test was failing because of a missing environment set. I
guess that happened because the test runner doesn't include it like it
is included locally so I removed that check so the test shouldn't be
flaky.
@kibanamachine kibanamachine reopened this Jul 7, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.9

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.9

kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jul 12, 2023
@jennypavlova
[Infra UI] Hosts flyout test fix (elastic#161244)
3c0338e 
Closes elastic#159368

## Summary

I saw that the test was failing because of a missing environment set. I
guess that happened because the test runner doesn't include it like it
is included locally so I removed that check so the test shouldn't be
flaky.

(cherry picked from commit 9d57196)
kibanamachine added a commit that referenced this issue Jul 12, 2023
@kibanamachine @jennypavlova
[8.9] [Infra UI] Hosts flyout test fix (#161244) (#161767)
8c14f31 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Infra UI] Hosts flyout test fix
(#161244)](#161244)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-06T07:50:40Z","message":"[Infra
UI] Hosts flyout test fix (#161244)\n\nCloses #159368 \r\n\r\n##
Summary\r\n\r\nI saw that the test was failing because of a missing
environment set. I\r\nguess that happened because the test runner
doesn't include it like it\r\nis included locally so I removed that
check so the test shouldn't
be\r\nflaky.","sha":"9d57196a54ebe7816d2739ee5b85dcc76a71b253","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra
Monitoring
UI","release_note:skip","backport:prev-minor","v8.10.0"],"number":161244,"url":"https://github.com/elastic/kibana/pull/161244","mergeCommit":{"message":"[Infra
UI] Hosts flyout test fix (#161244)\n\nCloses #159368 \r\n\r\n##
Summary\r\n\r\nI saw that the test was failing because of a missing
environment set. I\r\nguess that happened because the test runner
doesn't include it like it\r\nis included locally so I removed that
check so the test shouldn't
be\r\nflaky.","sha":"9d57196a54ebe7816d2739ee5b85dcc76a71b253"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161244","number":161244,"mergeCommit":{"message":"[Infra
UI] Hosts flyout test fix (#161244)\n\nCloses #159368 \r\n\r\n##
Summary\r\n\r\nI saw that the test was failing because of a missing
environment set. I\r\nguess that happened because the test runner
doesn't include it like it\r\nis included locally so I removed that
check so the test shouldn't
be\r\nflaky.","sha":"9d57196a54ebe7816d2739ee5b85dcc76a71b253"}}]}]
BACKPORT-->

Co-authored-by: jennypavlova <[email protected]>
@smith
Copy link
Contributor

smith commented Jul 13, 2023

I think the referenced commits above will fix this.

@smith smith closed this as completed Jul 13, 2023
@kibanamachine kibanamachine reopened this Jul 17, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Jul 18, 2023
@mistic
skip flaky suite (#159368, #162051)
0aa5b21
@mistic
Copy link
Member

mistic commented Jul 18, 2023

Skipped.

main: 0aa5b21

@jennypavlova jennypavlova mentioned this issue Jul 18, 2023
Merged
jennypavlova added a commit that referenced this issue Jul 19, 2023
@jennypavlova @kibanamachine
[Infra UI] Hosts view test: fix apm services link (#162147)
e98abd0 
Closes #162051
Closes #159368
## Summary

This PR aims to make the APM services link test more stable. For some
reason, some of the query parameters are not present in the URL the
moment we navigate but we can see in the screenshot that the correct
dates are applied (it could be that the moment we load APM the URL is
not updated - when checking locally those parameters exist in the URL)
<img width="1612" alt="image"
src="https://github.com/elastic/kibana/assets/14139027/2363108a-329e-4f28-a0d8-9f177d01d4ef">

---------

Co-authored-by: Kibana Machine <[email protected]>
jennypavlova added a commit to jennypavlova/kibana that referenced this issue Jul 19, 2023
@jennypavlova
[Infra UI] Hosts view test: fix apm services link (elastic#162147)
51c93d5 
Closes elastic#162051
Closes elastic#159368
## Summary

This PR aims to make the APM services link test more stable. For some
reason, some of the query parameters are not present in the URL the
moment we navigate but we can see in the screenshot that the correct
dates are applied (it could be that the moment we load APM the URL is
not updated - when checking locally those parameters exist in the URL)
<img width="1612" alt="image"
src="https://github.com/elastic/kibana/assets/14139027/2363108a-329e-4f28-a0d8-9f177d01d4ef">

---------

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit e98abd0)

# Conflicts:
#	x-pack/test/functional/apps/infra/hosts_view.ts
jennypavlova added a commit that referenced this issue Jul 19, 2023
@jennypavlova @kibanamachine
[8.9] [Infra UI] Hosts view test: fix apm services link (#162147) (#1…
f071fb3 
…62216)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Infra UI] Hosts view test: fix apm services link
(#162147)](#162147)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-19T08:30:43Z","message":"[Infra
UI] Hosts view test: fix apm services link (#162147)\n\nCloses
https://github.com/elastic/kibana/issues/162051\r\nCloses #159368\r\n##
Summary\r\n\r\nThis PR aims to make the APM services link test more
stable. For some\r\nreason, some of the query parameters are not present
in the URL the\r\nmoment we navigate but we can see in the screenshot
that the correct\r\ndates are applied (it could be that the moment we
load APM the URL is\r\nnot updated - when checking locally those
parameters exist in the URL)\r\n<img width=\"1612\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/2363108a-329e-4f28-a0d8-9f177d01d4ef\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"e98abd0fb5896b573de7ab811534d134d15d7cb9","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra
Monitoring
UI","release_note:skip","backport:prev-minor","v8.10.0"],"number":162147,"url":"https://github.com/elastic/kibana/pull/162147","mergeCommit":{"message":"[Infra
UI] Hosts view test: fix apm services link (#162147)\n\nCloses
https://github.com/elastic/kibana/issues/162051\r\nCloses #159368\r\n##
Summary\r\n\r\nThis PR aims to make the APM services link test more
stable. For some\r\nreason, some of the query parameters are not present
in the URL the\r\nmoment we navigate but we can see in the screenshot
that the correct\r\ndates are applied (it could be that the moment we
load APM the URL is\r\nnot updated - when checking locally those
parameters exist in the URL)\r\n<img width=\"1612\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/2363108a-329e-4f28-a0d8-9f177d01d4ef\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"e98abd0fb5896b573de7ab811534d134d15d7cb9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162147","number":162147,"mergeCommit":{"message":"[Infra
UI] Hosts view test: fix apm services link (#162147)\n\nCloses
https://github.com/elastic/kibana/issues/162051\r\nCloses #159368\r\n##
Summary\r\n\r\nThis PR aims to make the APM services link test more
stable. For some\r\nreason, some of the query parameters are not present
in the URL the\r\nmoment we navigate but we can see in the screenshot
that the correct\r\ndates are applied (it could be that the moment we
load APM the URL is\r\nnot updated - when checking locally those
parameters exist in the URL)\r\n<img width=\"1612\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/2363108a-329e-4f28-a0d8-9f177d01d4ef\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"e98abd0fb5896b573de7ab811534d134d15d7cb9"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@mistic
skip flaky suite (elastic#159368, elastic#162051)
efa762d
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@jennypavlova @kibanamachine
[Infra UI] Hosts view test: fix apm services link (elastic#162147)
fa2947c 
Closes elastic#162051
Closes elastic#159368
## Summary

This PR aims to make the APM services link test more stable. For some
reason, some of the query parameters are not present in the URL the
moment we navigate but we can see in the screenshot that the correct
dates are applied (it could be that the moment we load APM the URL is
not updated - when checking locally those parameters exist in the URL)
<img width="1612" alt="image"
src="https://github.com/elastic/kibana/assets/14139027/2363108a-329e-4f28-a0d8-9f177d01d4ef">

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennypavlova jennypavlova

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
5 participants
@smith @mistic @jennypavlova @elasticmachine @kibanamachine