[Infra UI] Hosts flyout test fix #161244
Merged
[Infra UI] Hosts flyout test fix #161244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennypavlova
added
Team:Infra Monitoring UI - DEPRECATED
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
|
Passed 50 times [build] |
kibanamachine
added
v8.10.0
backport:skip
jennypavlova
added
backport:prev-minor
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 12, 2023
Closes elastic#159368 ## Summary I saw that the test was failing because of a missing environment set. I guess that happened because the test runner doesn't include it like it is included locally so I removed that check so the test shouldn't be flaky. (cherry picked from commit 9d57196)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 12, 2023
# Backport This will backport the following commits from `main` to `8.9`: - [[Infra UI] Hosts flyout test fix (#161244)](#161244) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-06T07:50:40Z","message":"[Infra UI] Hosts flyout test fix (#161244)\n\nCloses #159368 \r\n\r\n## Summary\r\n\r\nI saw that the test was failing because of a missing environment set. I\r\nguess that happened because the test runner doesn't include it like it\r\nis included locally so I removed that check so the test shouldn't be\r\nflaky.","sha":"9d57196a54ebe7816d2739ee5b85dcc76a71b253","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra Monitoring UI","release_note:skip","backport:prev-minor","v8.10.0"],"number":161244,"url":"https://github.com/elastic/kibana/pull/161244","mergeCommit":{"message":"[Infra UI] Hosts flyout test fix (#161244)\n\nCloses #159368 \r\n\r\n## Summary\r\n\r\nI saw that the test was failing because of a missing environment set. I\r\nguess that happened because the test runner doesn't include it like it\r\nis included locally so I removed that check so the test shouldn't be\r\nflaky.","sha":"9d57196a54ebe7816d2739ee5b85dcc76a71b253"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161244","number":161244,"mergeCommit":{"message":"[Infra UI] Hosts flyout test fix (#161244)\n\nCloses #159368 \r\n\r\n## Summary\r\n\r\nI saw that the test was failing because of a missing environment set. I\r\nguess that happened because the test runner doesn't include it like it\r\nis included locally so I removed that check so the test shouldn't be\r\nflaky.","sha":"9d57196a54ebe7816d2739ee5b85dcc76a71b253"}}]}] BACKPORT--> Co-authored-by: jennypavlova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #159368
Summary
I saw that the test was failing because of a missing environment set. I guess that happened because the test runner doesn't include it like it is included locally so I removed that check so the test shouldn't be flaky.