Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.9] [Infra UI] Hosts view test: fix apm services link (#162147) #162216

Merged
merged 2 commits into from
Jul 19, 2023
Merged

[8.9] [Infra UI] Hosts view test: fix apm services link (#162147) #162216

merged 2 commits into from
Jul 19, 2023

Conversation

jennypavlova
Copy link
Member

Backport

This will backport the following commits from main to 8.9:

Questions ?

Please refer to the Backport tool documentation

@jennypavlova
[Infra UI] Hosts view test: fix apm services link (elastic#162147)
51c93d5 
Closes elastic#162051
Closes elastic#159368
## Summary

This PR aims to make the APM services link test more stable. For some
reason, some of the query parameters are not present in the URL the
moment we navigate but we can see in the screenshot that the correct
dates are applied (it could be that the moment we load APM the URL is
not updated - when checking locally those parameters exist in the URL)
<img width="1612" alt="image"
src="https://github.com/elastic/kibana/assets/14139027/2363108a-329e-4f28-a0d8-9f177d01d4ef">

---------

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit e98abd0)

# Conflicts:
#	x-pack/test/functional/apps/infra/hosts_view.ts
@jennypavlova jennypavlova enabled auto-merge (squash) July 19, 2023 08:47
@jennypavlova jennypavlova mentioned this pull request Jul 19, 2023
Merged
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

crespocarlos
crespocarlos approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏

@jennypavlova jennypavlova merged commit f071fb3 into elastic:8.9 Jul 19, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 415 419 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 496 500 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crespocarlos crespocarlos crespocarlos approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jennypavlova @apmmachine @kibana-ci @crespocarlos @kibanamachine