-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Ensure links are distinguished from surrounding text in a way that does not rely on color validation error on Overview page #154294
Comments
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Pinging @elastic/ml-ui (:ml) |
cc @1Copenut thanks |
cc @elastic/kibana-design this seems like a generic issue. So will need inputs. Thanks :) |
@bhavyarm Here's a few thoughts on this:
Here's a mockup showing these changes:
cc/ @szabosteve for some extra copy help—I tried condensing the Transform callout from the docs, but would be good to get your eyes on it. Thank you! |
Hi @mdefazio, 👋 I would suggest only some minor changes in the transform callout text.
WDYT? (A side note: The transforms app contains a link to the transforms documentation, so I agree that linking to the transforms docs here in the empty state is not necessary.) |
Works for me! Thanks for taking a look. |
Linking related (wider) issue: #154570 |
@mdefazio Removing the accent links from the block of text meets the ask to my thinking. I think this solution works, with a caveat that we may end up revisiting it if so requested. Links that stand away from other elements (low to no proximity) are easier to justify without underlines or icons, because their deliberate offset / placement gives them a subtle suggestion of action. |
Moving to 8.9.0, where we plan to address this issue as part of wider changes planned for the Overview page. |
## Summary Resolves #154294 and updates the UI of the Overview page - Updates panels layout - Stores expand/collapsed state of the panels in the local storage - Update empty states text and layout <img width="1341" alt="image" src="https://github.com/elastic/kibana/assets/5236598/8833fa2a-b574-44ee-bacb-e974186dd35f"> ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
## Summary Resolves elastic#154294 and updates the UI of the Overview page - Updates panels layout - Stores expand/collapsed state of the panels in the local storage - Update empty states text and layout <img width="1341" alt="image" src="https://github.com/elastic/kibana/assets/5236598/8833fa2a-b574-44ee-bacb-e974186dd35f"> ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit 6ac52fb)
Kibana version: main
Browser version: chrome latest
Browser OS version: OS X
Describe the bug: These two links on ML overview page - transforms & entity-centric source data set here is failing the a11y validation rule:
The text was updated successfully, but these errors were encountered: