-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unskip ML a11y tests #154001
Unskip ML a11y tests #154001
Conversation
It looks like with the provided fix, we now run into some follow-up failures. I've tracked that down to the following items (everything else failing looks just to be a result from earlier failures and thus incomplete test steps - the run doesn't stop on the first failure). 1. Link issue on the overview page
2. The same link issue, coming up on the validation step in all AD job wizards
3. Issue with a select name on the single metric viewer page
|
AFAIU @bhavyarm will check items 1 and 2 as this was coming up before. |
cc @1Copenut
Issue 1 and 2 - FYI. Thanks! |
Thanks for digging into the failures @pheyos. I'll see if I can get a quick fix in for item 3 |
@peteharverson @1Copenut and I zoomed about 1 and 2. I will log an issue for you. Looks like it needs more discussion. Thanks @pheyos |
The fix for the 'Interval' select for the anomalies table is up - #154185 |
This PR should now be unblocked after this #154185 was merged in |
|
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @bhavyarm |
closing this without merging & opening a new pr to unskip to make a clean start of weird test failures on this. |
Awesome ML team fixed their a11y bugs - #153596 & #153592 which I logged while doing axe-core engine update
Unskipping ML a11Y tests