Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add UI tests for Integration Policy upgrades with conflicts #125236

Closed
3 tasks
joshdover opened this issue Feb 10, 2022 · 7 comments · Fixed by #137190
Closed
3 tasks

[Fleet] Add UI tests for Integration Policy upgrades with conflicts #125236

joshdover opened this issue Feb 10, 2022 · 7 comments · Fixed by #137190
Assignees
Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture tests_needed v8.3.0

Comments

@joshdover
Copy link
Contributor

joshdover commented Feb 10, 2022

See #121436 for tracking of all Fleet UI tests and for guidance on how to structure and write Cypress tests.

Basic coverage for editing an integration (the description field) was added in #121628
Unit tests for validation and saving were added in #125068

We need to have additional coverage that exercises some of the more complex aspects of the policy editor. This is scoped to:

  • Integration policy upgrades - this involves more complex interactions with the backend. We have existing coverage of the happy path, need to handle the 'conflict' scenario.
    • When there are conflicts, the user should see a warning callout
    • Form should not save without fixing conflicts

We should use a test package defined in the Kibana repository and served via the local EPR docker container for this type of testing rather than using a real package that will change between releases. We are tracking tests for the specific custom UIs separately, such as #123399

@joshdover joshdover added tests_needed technical debt Improvement of the software architecture and operational architecture Team:Fleet Team label for Observability Data Collection Fleet team labels Feb 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@juliaElastic
Copy link
Contributor

I've added unit tests for many of these scenarios here: #125068
I'm not sure we need cypress tests as well, since the form validation/submit button is UI only functionality.

@joshdover
Copy link
Contributor Author

@juliaElastic Thanks I forgot to look at the coverage available there. I've scoped this down to focus on package policy upgrades which are more complex. I think the other coverage we've added in the past few weeks covers the other scenarios well.

@joshdover joshdover changed the title [Fleet] Add UI tests for Integration Policy editor [Fleet] Add UI tests for Integration Policy upgrades with conflicts Feb 10, 2022
@criamico criamico self-assigned this Feb 21, 2022
@criamico
Copy link
Contributor

@juliaElastic do you know if we already have a dockerized package registry running in Cypress? If not we'll have to create the basic setup needed to write these tests.

@juliaElastic
Copy link
Contributor

@criamico we are not using dockerized package registry with Cypress, you can force install earlier versions of packages to test conflicts.
I'm not sure if we want to use a docker registry or keep using the actual snapshot registry, maybe we should discuss #121436 (comment)

@criamico
Copy link
Contributor

Thanks Julia, I think it's worth exploring the different options. I'll check the other discussion.

@joshdover
Copy link
Contributor Author

joshdover commented Apr 1, 2022

@criamico Instead of using a dockerized EPR, could we explore using the upload package API for this use case? We're already discussing getting rid of the EPR docker image in #128522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture tests_needed v8.3.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants