-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Remove EPR container from FTR tests #128522
Comments
Pinging @elastic/fleet (Team:Fleet) |
#129367 needs to be solved before we can remove the EPR image |
|
Lets assume for a moment all tests packages and bundled packages are in Kibana. So for testing these packages, the registry is not needed anymore. But that still means we don't do any tests against the actual registry / most recent changes of the registry. I think of this similar to testing against SNAPSHOT of Elasticsearch except that in the registry scenario it is very likely a version that is already out there. In the early days of the package-registry, there were breaking changes between minors and the package-registry tests made Kibana fail. So the container + specific version was attached to Kibana. The package-registry is now stable and breaking the API is not an option as it needs to be compatible with older versions of Kibana. If any package-registry change broke Kibana, we should know ASAP. There are several ways on how to solve this:
I expect we already e2e tests in place that covers this but I'm in favour of option 2. Kibana (Integrations / Fleet) by now considers the registry to almost always be there. If we have registry, someone creating tests against certain packages can just do it. Today the hash we test against is hardcoded. This is to ensure reproducible builds. Instead of manually updating the registry when changes happens, this should happen each time a PR to package-registry are merged (do we also need to consider package-spec). The current version of the package-registry is 1.8.0 and the next upcoming is 1.8.1. As soon as 1.8.0 is released and the version in the package-registry is updated, a pull request against Kibana would be opened to test against Having this would mean:
My understanding is that so far this docker setup for the registry did not really cause issues? |
As per discussion in #116591 (comment), we believe we no longer need the EPR container for running functional tests due to the fact that we are now bundling all packages that we have tests for in the Kibana suite.
We should remove this from all test suites and rely on the bundled packages instead.
The text was updated successfully, but these errors were encountered: