[Fleet] Edit package policy tests #125068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
release_note:skip
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
juliaElastic
commented
Feb 9, 2022
| * [observability-test-environments](https://github.com/elastic/observability-test-environments): internal project, uses Fleet API [Check here](https://github.com/elastic/observability-test-environments/blob/master/ansible/tasks-fleet-config.yml) | ||
| * [ECK](https://github.com/elastic/cloud-on-k8s): Elastic Cloud on Kubernetes, orchestrates Elastic Stack applications, including Kibana with Fleet (no direct dependency, has examples that include Fleet config) [Check here](https://github.com/elastic/cloud-on-k8s/blob/main/docs/orchestrating-elastic-stack-applications/agent-fleet.asciidoc) | ||
| * [APM Server](https://github.com/elastic/apm-server) APM Server, receives data from Elastic APM agents. Using docker compose for testing. [Check here](https://github.com/elastic/apm-server/pull/7227/files) |
There was a problem hiding this comment.
added APM Server dependency to README
juliaElastic
commented
Feb 9, 2022
| @@ -347,6 +347,8 @@ export const EditPackagePolicyForm = memo<{ | |||
| : false; | |||
| if (!hasValidationErrors) { | |||
| setFormState('VALID'); | |||
| } else { | |||
| setFormState('INVALID'); | |||
There was a problem hiding this comment.
this is actually a bugfix that create page had as well, form didn't become invalid when clearing a required form input
juliaElastic
commented
Feb 9, 2022
| @@ -105,7 +105,8 @@ export const PackagePolicyInputConfig: React.FunctionComponent<{ | |||
| <EuiFlexGroup direction="column" gutterSize="m"> | |||
| {requiredVars.map((varDef) => { | |||
| const { name: varName, type: varType } = varDef; | |||
| const { value, frozen } = packagePolicyInput.vars![varName]; | |||
| if (!packagePolicyInput.vars) return; | |||
| const { value, frozen } = packagePolicyInput.vars[varName]; | |||
There was a problem hiding this comment.
Added these nullchecks as I kept getting js undefined errors while testing locally the upgrade page of aws. There is a short time initially when those variables are undefined, making the form unusable.
💛 Build succeeded, but was flakyTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 10, 2022
* edit package policy test * moved out styled component, added null checks * added tests for submit (cherry picked from commit f693a23)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
3 tasks
kibanamachine
added a commit
that referenced
this pull request
Feb 10, 2022
* edit package policy test * moved out styled component, added null checks * added tests for submit (cherry picked from commit f693a23) Co-authored-by: Julia Bardi <[email protected]>
This was referenced Feb 21, 2022
kpollich
added a commit
to kpollich/kibana
that referenced
this pull request
Jul 26, 2022
kpollich
added a commit
that referenced
this pull request
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added unit tests for Edit package policy covering forceUpgrade flag too.
Related to #123819